diff mbox

ARC: unbork buildroot build

Message ID 1387891517-16624-1-git-send-email-vgupta@synopsys.com
State Accepted, archived
Headers show

Commit Message

Vineet Gupta Dec. 24, 2013, 1:25 p.m. UTC
crt1.S -> include sysdep.h -> include sysnum.h

In multistage gcc build, Buildroot happens to build crt1.S before
sysnum.h is generated. So break the above include chain and opencode the
ENTRY/END macros.

Reported-by: Anton Kolesov <akolesov@synopsys.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
 libc/sysdeps/linux/arc/crt1.S | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Bernhard Reutner-Fischer Jan. 8, 2014, 11:44 a.m. UTC | #1
On Tue, Dec 24, 2013 at 06:55:17PM +0530, Vineet Gupta wrote:
> crt1.S -> include sysdep.h -> include sysnum.h
> 
> In multistage gcc build, Buildroot happens to build crt1.S before
> sysnum.h is generated. So break the above include chain and opencode the
> ENTRY/END macros.
> 
> Reported-by: Anton Kolesov <akolesov@synopsys.com>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

Again, you From: addr != SOB-addr, thus fixed and pushed.
thanks,
diff mbox

Patch

diff --git a/libc/sysdeps/linux/arc/crt1.S b/libc/sysdeps/linux/arc/crt1.S
index d78a96dcc4fb..95c41f888850 100644
--- a/libc/sysdeps/linux/arc/crt1.S
+++ b/libc/sysdeps/linux/arc/crt1.S
@@ -5,7 +5,6 @@ 
  */
 
 #include <features.h>
-#include <sysdep.h>
 
 .text
 
@@ -31,7 +30,12 @@ 
         env[0...N]      environment variables (pointers)
         NULL
 */
-ENTRY(__start)
+	.text
+	.align 4
+	.global __start
+	.hidden __start
+	.type __start,@function
+__start:
 	mov	fp, 0
 	ld_s	r1, [sp]	; argc
 
@@ -50,5 +54,4 @@  ENTRY(__start)
 
 	/* Should never get here....  */
 	flag    1
-END(__start)
-libc_hidden_def(__start)
+.size __start,.-__start