| Message ID | 1389050419-9060-1-git-send-email-bpoirier@suse.de |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Benjamin Poirier <bpoirier@suse.de> Date: Mon, 6 Jan 2014 18:20:19 -0500 > There are many cases where this feature does not improve performance or even > reduces it. See the following discussion for example perf numbers: > http://thread.gmane.org/gmane.linux.network/298345 > > CC: Tom Herbert <therbert@google.com> > Signed-off-by: Benjamin Poirier <bpoirier@suse.de> Please don't provide data via a URL, which is transient. Instead, include it inline in the commit message proper. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index 153ee2f..2e242583 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5783,13 +5783,8 @@ int register_netdevice(struct net_device *dev) dev->features |= NETIF_F_SOFT_FEATURES; dev->wanted_features = dev->features & dev->hw_features; - /* Turn on no cache copy if HW is doing checksum */ if (!(dev->flags & IFF_LOOPBACK)) { dev->hw_features |= NETIF_F_NOCACHE_COPY; - if (dev->features & NETIF_F_ALL_CSUM) { - dev->wanted_features |= NETIF_F_NOCACHE_COPY; - dev->features |= NETIF_F_NOCACHE_COPY; - } } /* Make NETIF_F_HIGHDMA inheritable to VLAN devices.
There are many cases where this feature does not improve performance or even reduces it. See the following discussion for example perf numbers: http://thread.gmane.org/gmane.linux.network/298345 CC: Tom Herbert <therbert@google.com> Signed-off-by: Benjamin Poirier <bpoirier@suse.de> --- net/core/dev.c | 5 ----- 1 file changed, 5 deletions(-)