| Message ID | 1387570460-18409-1-git-send-email-ezequiel.garcia@free-electrons.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 12/20/2013 11:14 PM, Ezequiel Garcia wrote: > OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus > SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this > depend on OMAP3 only. Take an extra step, to get wider build coverage, and make > the driver depend on ARM. To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT' to 'depends on ARCH_OMAP2PLUS'? > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Dec 21, 2013 at 12:17:27AM +0300, Sergei Shtylyov wrote: > On 12/20/2013 11:14 PM, Ezequiel Garcia wrote: > > > OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus > > SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this > > depend on OMAP3 only. Take an extra step, to get wider build coverage, and make > > the driver depend on ARM. > > To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT' > to 'depends on ARCH_OMAP2PLUS'? > Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail in v2). I'd say it's Marc's call.
On 12/20/2013 10:33 PM, Ezequiel Garcia wrote: > On Sat, Dec 21, 2013 at 12:17:27AM +0300, Sergei Shtylyov wrote: >> On 12/20/2013 11:14 PM, Ezequiel Garcia wrote: >> >>> OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus >>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this >>> depend on OMAP3 only. Take an extra step, to get wider build coverage, and make >>> the driver depend on ARM. >> >> To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT' >> to 'depends on ARCH_OMAP2PLUS'? > Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail > in v2). I'd say it's Marc's call. Convinced, I've added the v1 of this patch to can-next together with a || COMIPLE_TEXT. regards, Marc
On 12/21/2013 11:16 PM, Sergei Shtylyov wrote: > Hello. > > On 12/22/2013 12:06 AM, Marc Kleine-Budde wrote: > >>>>> OMAP's ti_hecc driver is used to support the CAN controller on many >>>>> omap2plus >>>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to >>>>> make this >>>>> depend on OMAP3 only. Take an extra step, to get wider build >>>>> coverage, and make >>>>> the driver depend on ARM. > >>>> To have a real wide coverage, it's probably worth adding '|| >>>> COMIPLE_TEXT' >>>> to 'depends on ARCH_OMAP2PLUS'? > >>> Yup, and that was my exact proposal on my reply to v1 (which I forgot >>> to detail >>> in v2). I'd say it's Marc's call. > >> Convinced, I've added the v1 of this patch to can-next together with a >> || COMIPLE_TEXT. > > Sorry, I meant COMPILE_TEST, of course. :-< lol, I copy/pasted the || COMIPLE_TEXT from you, but in the patch I added the correct COMPILE_TEST: - depends on ARCH_OMAP3 + depends on ARCH_OMAP2PLUS || COMPILE_TEST Marc
Hello. On 12/22/2013 12:06 AM, Marc Kleine-Budde wrote: >>>> OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus >>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this >>>> depend on OMAP3 only. Take an extra step, to get wider build coverage, and make >>>> the driver depend on ARM. >>> To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT' >>> to 'depends on ARCH_OMAP2PLUS'? >> Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail >> in v2). I'd say it's Marc's call. > Convinced, I've added the v1 of this patch to can-next together with a > || COMIPLE_TEXT. Sorry, I meant COMPILE_TEST, of course. :-< > regards, > Marc WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 3c06947..9e7d95d 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -71,7 +71,7 @@ config CAN_AT91 and AT91SAM9X5 processors. config CAN_TI_HECC - depends on ARCH_OMAP3 + depends on ARM tristate "TI High End CAN Controller" ---help--- Driver for TI HECC (High End CAN Controller) module found on many
OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this depend on OMAP3 only. Take an extra step, to get wider build coverage, and make the driver depend on ARM. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)