| Message ID | 1387542110-26596-1-git-send-email-ezequiel.garcia@free-electrons.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 12/20/2013 01:21 PM, Ezequiel Garcia wrote: > OMAP's ti_hecc driver is used to support the CAN controller on many > omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x). > Constrain the driver to OMAP2PLUS, which is the super-set of all the > other SoCs variants. Why not enable it for all ARM platforms to get a bigger compile coverage? Marc
On Fri, Dec 20, 2013 at 01:35:58PM +0100, Marc Kleine-Budde wrote: > On 12/20/2013 01:21 PM, Ezequiel Garcia wrote: > > OMAP's ti_hecc driver is used to support the CAN controller on many > > omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x). > > Constrain the driver to OMAP2PLUS, which is the super-set of all the > > other SoCs variants. > > Why not enable it for all ARM platforms to get a bigger compile coverage? > Hm.. Isn't the COMPILE_TEST option for getting compile coverage? If the IP is only available on OMAP SoCs, it makes sense to only allow building it there, but I don't really have a strong opinion.
On 12/20/2013 01:52 PM, Ezequiel Garcia wrote: > On Fri, Dec 20, 2013 at 01:35:58PM +0100, Marc Kleine-Budde wrote: >> On 12/20/2013 01:21 PM, Ezequiel Garcia wrote: >>> OMAP's ti_hecc driver is used to support the CAN controller on many >>> omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x). >>> Constrain the driver to OMAP2PLUS, which is the super-set of all the >>> other SoCs variants. >> >> Why not enable it for all ARM platforms to get a bigger compile coverage? >> > > Hm.. Isn't the COMPILE_TEST option for getting compile coverage? > > If the IP is only available on OMAP SoCs, it makes sense to only allow > building it there, but I don't really have a strong opinion. We've replaced the depends on ARCH_* in the flexcan and at91 driver by a depends on ARM. Marc
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 3c06947..f0b106b 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -71,7 +71,7 @@ config CAN_AT91 and AT91SAM9X5 processors. config CAN_TI_HECC - depends on ARCH_OMAP3 + depends on ARCH_OMAP2PLUS tristate "TI High End CAN Controller" ---help--- Driver for TI HECC (High End CAN Controller) module found on many
OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x). Constrain the driver to OMAP2PLUS, which is the super-set of all the other SoCs variants. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)