diff mbox

bnx2x: downgrade "valid ME register value" message level

Message ID 1387302685-32314-1-git-send-email-mschmidt@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Michal Schmidt Dec. 17, 2013, 5:51 p.m. UTC
"valid ME register value" is not an error. It should be logged for
debugging only.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yuval Mintz Dec. 18, 2013, 6:37 a.m. UTC | #1
> "valid ME register value" is not an error. It should be logged for
> debugging only.
> 
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>

Yep, that's true; Thanks Michal.

Acked-by: Yuval Mintz <yuvalmin@broadcom.com>

> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> index efa8a15..3dc2537 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
> @@ -208,7 +208,7 @@ static int bnx2x_get_vf_id(struct bnx2x *bp, u32
> *vf_id)
>  		return -EINVAL;
>  	}
> 
> -	BNX2X_ERR("valid ME register value: 0x%08x\n", me_reg);
> +	DP(BNX2X_MSG_IOV, "valid ME register value: 0x%08x\n", me_reg);
> 
>  	*vf_id = (me_reg & ME_REG_VF_NUM_MASK) >>
> ME_REG_VF_NUM_SHIFT;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Dec. 19, 2013, 8:17 p.m. UTC | #2
From: Michal Schmidt <mschmidt@redhat.com>
Date: Tue, 17 Dec 2013 18:51:25 +0100

> "valid ME register value" is not an error. It should be logged for
> debugging only.
> 
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
index efa8a15..3dc2537 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c
@@ -208,7 +208,7 @@  static int bnx2x_get_vf_id(struct bnx2x *bp, u32 *vf_id)
 		return -EINVAL;
 	}
 
-	BNX2X_ERR("valid ME register value: 0x%08x\n", me_reg);
+	DP(BNX2X_MSG_IOV, "valid ME register value: 0x%08x\n", me_reg);
 
 	*vf_id = (me_reg & ME_REG_VF_NUM_MASK) >> ME_REG_VF_NUM_SHIFT;