diff mbox

RFA: revert libstdc++ r205810: simulator workload increase caused regression

Message ID 201312150657.rBF6vN07014290@ignucius.se.axis.com
State New
Headers show

Commit Message

Hans-Peter Nilsson Dec. 15, 2013, 6:57 a.m. UTC 
From the revision range 205803:205810 (excluding:including) an
on, my autotester for cris-elf reports a regression:

Running /tmp/hpautotest-gcc1/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ...
WARNING: program timed out.
FAIL: 20_util/hash/chi2_quality.cc execution test

This appears to have come from revision r205810.  I can't find
the discussion or approval leading to that commit.  It seems
likely to have been a mistake, perhaps a commit intended for a
local repository.  Why else increase the workload, without
discussion with other target maintainers known to risk being
affected by this change?  The somewhat obvious fix is to just
revert revision r205810.

CC to committer and author from ChangeLog.

Ok to commit?

libstdc++:
	* testsuite/20_util/hash/chi2_quality.cc: Revert previous change.


brgds, H-P

Comments

Jonathan Wakely Dec. 15, 2013, 10:38 a.m. UTC | #1 
On Dec 15, 2013 6:57 AM, "Hans-Peter Nilsson"
<hans-peter.nilsson@axis.com> wrote:
>
> From the revision range 205803:205810 (excluding:including) an
> on, my autotester for cris-elf reports a regression:
>
> Running /tmp/hpautotest-gcc1/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ...
> WARNING: program timed out.
> FAIL: 20_util/hash/chi2_quality.cc execution test
>
> This appears to have come from revision r205810.  I can't find
> the discussion

http://gcc.gnu.org/ml/libstdc++/2013-10/msg00233.html

> or approval leading to that commit.

http://gcc.gnu.org/ml/libstdc++/2013-11/msg00098.html


>  It seems
> likely to have been a mistake, perhaps a commit intended for a
> local repository.  Why else increase the workload, without
> discussion with other target maintainers known to risk being
> affected by this change?  The somewhat obvious fix is to just
> revert revision r205810.
>
> CC to committer and author from ChangeLog.
>
> Ok to commit?
>
> libstdc++:
>         * testsuite/20_util/hash/chi2_quality.cc: Revert previous change.
>
> Index: testsuite/20_util/hash/chi2_quality.cc
> ===================================================================
> --- testsuite/20_util/hash/chi2_quality.cc      (revision 205810)
> +++ testsuite/20_util/hash/chi2_quality.cc      (revision 205809)
> @@ -1,7 +1,7 @@
>  // { dg-options "-std=gnu++0x" }
>
>  // Use smaller statistics when running on simulators, so it takes less time.
> -// { dg-options "-std=gnu++0x -DSAMPLES=30000" { target simulator } }
> +// { dg-options "-std=gnu++0x -DSAMPLES=10000" { target simulator } }
>
>  // Copyright (C) 2010-2013 Free Software Foundation, Inc.
>  //
>
> brgds, H-P
diff mbox

Patch

Index: testsuite/20_util/hash/chi2_quality.cc
===================================================================
--- testsuite/20_util/hash/chi2_quality.cc	(revision 205810)
+++ testsuite/20_util/hash/chi2_quality.cc	(revision 205809)
@@ -1,7 +1,7 @@ 
 // { dg-options "-std=gnu++0x" }
 
 // Use smaller statistics when running on simulators, so it takes less time.
-// { dg-options "-std=gnu++0x -DSAMPLES=30000" { target simulator } }
+// { dg-options "-std=gnu++0x -DSAMPLES=10000" { target simulator } }
 
 // Copyright (C) 2010-2013 Free Software Foundation, Inc.
 //