| Message ID | 1385360833-26879-4-git-send-email-sonic.adi@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Sonic Zhang |
| Headers | show |
Hello Sonic, Am 25.11.2013 07:27, schrieb Sonic Zhang: > From: Sonic Zhang<sonic.zhang@analog.com> > > Use default GPIO operations. > > Signed-off-by: Sonic Zhang<sonic.zhang@analog.com> > --- > include/configs/bf533-stamp.h | 29 ++--------------------------- > 1 file changed, 2 insertions(+), 27 deletions(-) Is this the same patch you posted here: http://patchwork.ozlabs.org/patch/292026/ ? I have the "old" patch on my ToDo list, but I can Ack the new patch, if it should go through the blackfin repo ... added Mike Frysinger to cc ... bye, Heiko
Hi Heiko, The second patch is to address Masahiro Yamada's concern on the title format. No change to the content. Mike is no longer with ADI and Blackfin. If you prefer to go through the Blackfin repo, I can handle it. Regards, Sonic >-----Original Message----- >From: Heiko Schocher [mailto:hs@denx.de] >Sent: Monday, November 25, 2013 2:51 PM >To: Sonic Zhang >Cc: Masahiro Yamada; u-boot@lists.denx.de; adi-u-boot-devel@lists.sourceforge.net; >Zhang, Sonic; Mike Frysinger >Subject: Re: [PATCH 4/4 v2] blackfin: soft-i2c: No need to define blackfin specific soft >i2c operations > >Hello Sonic, > >Am 25.11.2013 07:27, schrieb Sonic Zhang: >> From: Sonic Zhang<sonic.zhang@analog.com> >> >> Use default GPIO operations. >> >> Signed-off-by: Sonic Zhang<sonic.zhang@analog.com> >> --- >> include/configs/bf533-stamp.h | 29 ++--------------------------- >> 1 file changed, 2 insertions(+), 27 deletions(-) > >Is this the same patch you posted here: > >http://patchwork.ozlabs.org/patch/292026/ > >? > >I have the "old" patch on my ToDo list, but I can Ack the new patch, if it should go >through the blackfin repo ... added Mike Frysinger to cc ... > >bye, >Heiko >-- >DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Hello Sonic, Am 25.11.2013 07:27, schrieb Sonic Zhang: > From: Sonic Zhang<sonic.zhang@analog.com> > > Use default GPIO operations. > > Signed-off-by: Sonic Zhang<sonic.zhang@analog.com> > --- > include/configs/bf533-stamp.h | 29 ++--------------------------- > 1 file changed, 2 insertions(+), 27 deletions(-) Acked-by: Heiko Schocher <hs@denx.de> bye, Heiko
Hello Sonic, Am 25.11.2013 08:07, schrieb Zhang, Sonic: > Hi Heiko, > > The second patch is to address Masahiro Yamada's concern on the title format. No change to the content. Oh... you should note this after the "---" in your patch. > Mike is no longer with ADI and Blackfin. If you prefer to go through the Blackfin repo, I can handle it. Hmm... as you posted it in a patchserie now, I just Acked it ;-) Oh, maybe you can update "doc/git-mailrc" ? bye, Heiko
diff --git a/include/configs/bf533-stamp.h b/include/configs/bf533-stamp.h index a22c868..f5b9658 100644 --- a/include/configs/bf533-stamp.h +++ b/include/configs/bf533-stamp.h @@ -80,33 +80,8 @@ /* * Software (bit-bang) I2C driver configuration */ -#define PF_SCL PF3 -#define PF_SDA PF2 -#define I2C_INIT (*pFIO_DIR |= PF_SCL); asm("ssync;") -#define I2C_ACTIVE (*pFIO_DIR |= PF_SDA); \ - *pFIO_INEN &= ~PF_SDA; asm("ssync;") -#define I2C_TRISTATE (*pFIO_DIR &= ~PF_SDA); \ - *pFIO_INEN |= PF_SDA; asm("ssync;") -#define I2C_READ ((volatile)(*pFIO_FLAG_D & PF_SDA) != 0); \ - asm("ssync;") -#define I2C_SDA(bit) if (bit) { \ - *pFIO_FLAG_S = PF_SDA; \ - asm("ssync;"); \ - } \ - else { \ - *pFIO_FLAG_C = PF_SDA; \ - asm("ssync;"); \ - } -#define I2C_SCL(bit) if (bit) { \ - *pFIO_FLAG_S = PF_SCL; \ - asm("ssync;"); \ - } \ - else { \ - *pFIO_FLAG_C = PF_SCL; \ - asm("ssync;"); \ - } -#define I2C_DELAY udelay(5) /* 1/4 I2C clock duration */ - +#define CONFIG_SOFT_I2C_GPIO_SCL GPIO_PF3 +#define CONFIG_SOFT_I2C_GPIO_SDA GPIO_PF2 /* * Flash Settings