diff mbox

net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'

Message ID 1241791201-23960-1-git-send-email-w.sang@pengutronix.de
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Wolfram Sang May 8, 2009, 2 p.m. UTC
Initialize the irq-table with PHY_POLL. '-1' means the same now, but is
hardly maintainable.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: Pantelis Antoniou <pantelis.antoniou@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: netdev@vger.kernel.org
Cc: linuxppc-dev@ozlabs.org
---
 drivers/net/fs_enet/mii-fec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Grant Likely May 8, 2009, 3:55 p.m. UTC | #1
On Fri, May 8, 2009 at 8:00 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> Initialize the irq-table with PHY_POLL. '-1' means the same now, but is
> hardly maintainable.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Vitaly Bordug <vbordug@ru.mvista.com>
> Cc: Pantelis Antoniou <pantelis.antoniou@gmail.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: netdev@vger.kernel.org
> Cc: linuxppc-dev@ozlabs.org
> ---
>  drivers/net/fs_enet/mii-fec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
> index 28077cc..9eb5480 100644
> --- a/drivers/net/fs_enet/mii-fec.c
> +++ b/drivers/net/fs_enet/mii-fec.c
> @@ -166,7 +166,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
>                goto out_unmap_regs;
>
>        for (i = 0; i < PHY_MAX_ADDR; i++)
> -               new_bus->irq[i] = -1;
> +               new_bus->irq[i] = PHY_POLL;

This code no longer exists in net-next.

g.
Wolfram Sang May 8, 2009, 4:06 p.m. UTC | #2
> This code no longer exists in net-next.

EPIC FAIL! :/ I checked the powerpc-tree, but not linux-next. I'm sorry
for the noise, will improve!
diff mbox

Patch

diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
index 28077cc..9eb5480 100644
--- a/drivers/net/fs_enet/mii-fec.c
+++ b/drivers/net/fs_enet/mii-fec.c
@@ -166,7 +166,7 @@  static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
 		goto out_unmap_regs;
 
 	for (i = 0; i < PHY_MAX_ADDR; i++)
-		new_bus->irq[i] = -1;
+		new_bus->irq[i] = PHY_POLL;
 
 	while ((np = of_get_next_child(ofdev->node, np)))
 		if (!strcmp(np->type, "ethernet-phy"))