Message ID | 1241640919-4650-2-git-send-email-wd@denx.de |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: > From: Piotr Ziecik <kosmo@semihalf.com> > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: <netdev@vger.kernel.org> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: John Rigby <jcrigby@gmail.com> Not seeing much benefit to this patch, and the (non-existant) patch description doesn't really help me here either. g.
Dear Grant, In message <fa686aa40905061335q3a3c4cc7r33d77df655100531@mail.gmail.com> you wrote: > On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: > > From: Piotr Ziecik <kosmo@semihalf.com> > > > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > > Signed-off-by: Wolfgang Denk <wd@denx.de> > > Cc: <netdev@vger.kernel.org> > > Cc: Grant Likely <grant.likely@secretlab.ca> > > Cc: John Rigby <jcrigby@gmail.com> > > Not seeing much benefit to this patch, and the (non-existant) patch > description doesn't really help me here either. Please see next patch which then uses the ability to change the defaults. Best regards, Wolfgang Denk
On Wed, May 6, 2009 at 4:02 PM, Wolfgang Denk <wd@denx.de> wrote: > Dear Grant, > > In message <fa686aa40905061335q3a3c4cc7r33d77df655100531@mail.gmail.com> you wrote: >> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: >> > From: Piotr Ziecik <kosmo@semihalf.com> >> > >> > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> >> > Signed-off-by: Wolfgang Denk <wd@denx.de> >> > Cc: <netdev@vger.kernel.org> >> > Cc: Grant Likely <grant.likely@secretlab.ca> >> > Cc: John Rigby <jcrigby@gmail.com> >> >> Not seeing much benefit to this patch, and the (non-existant) patch >> description doesn't really help me here either. > > Please see next patch which then uses the ability to change the > defaults. Please state that in the patch description when you repost it. :-P g.
diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index a9cbc31..f996a1a 100644 --- a/drivers/net/fs_enet/fs_enet-main.c +++ b/drivers/net/fs_enet/fs_enet-main.c @@ -46,6 +46,15 @@ #include "fs_enet.h" +/* Driver tunables */ + +#define ENET_RX_RING_SIZE 32 +#define ENET_TX_RING_SIZE 32 +#define ENET_RX_COPYBREAK 240 + +#define ENET_USE_NAPI 1 +#define ENET_NAPI_WEIGHT 17 + /*************************************************/ MODULE_AUTHOR("Pantelis Antoniou <panto@intracom.gr>"); @@ -1057,11 +1066,11 @@ static int __devinit fs_enet_probe(struct of_device *ofdev, fpi->cp_command = *data; } - fpi->rx_ring = 32; - fpi->tx_ring = 32; - fpi->rx_copybreak = 240; - fpi->use_napi = 1; - fpi->napi_weight = 17; + fpi->rx_ring = ENET_RX_RING_SIZE; + fpi->tx_ring = ENET_TX_RING_SIZE; + fpi->rx_copybreak = ENET_RX_COPYBREAK; + fpi->use_napi = ENET_USE_NAPI; + fpi->napi_weight = ENET_NAPI_WEIGHT; ret = find_phy(ofdev->node, fpi); if (ret)