| Message ID | 1384184627-8102-1-git-send-email-spdawson@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi Simon, On Mon, Nov 11, 2013 at 03:43:47PM +0000, spdawson@gmail.com wrote: > From: Simon Dawson <spdawson@gmail.com> > > The libqmi build specifies -Werror in the CFLAGS by default. This causes > build failures such as the following. > > http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/ > > The -Werror flag can be disabled using a configuration switch. > > Signed-off-by: Simon Dawson <spdawson@gmail.com> > --- > package/libqmi/libqmi.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk > index 911b1a7..8bd4577 100644 > --- a/package/libqmi/libqmi.mk > +++ b/package/libqmi/libqmi.mk > @@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES > > LIBQMI_DEPENDENCIES = libglib2 > > +LIBQMI_CONF_OPT = --enable-more-warnings=yes A comment would be nice. Something like: # Disable -Werror baruch
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes: > From: Simon Dawson <spdawson@gmail.com> > The libqmi build specifies -Werror in the CFLAGS by default. This causes > build failures such as the following. > http://autobuild.buildroot.net/results/070/070449299aa9025c4bc6769524a6e22d66c92a65/ > The -Werror flag can be disabled using a configuration switch. > Signed-off-by: Simon Dawson <spdawson@gmail.com> > --- > package/libqmi/libqmi.mk | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk > index 911b1a7..8bd4577 100644 > --- a/package/libqmi/libqmi.mk > +++ b/package/libqmi/libqmi.mk > @@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES > LIBQMI_DEPENDENCIES = libglib2 > +LIBQMI_CONF_OPT = --enable-more-warnings=yes That's not immediately obvious. Looking at compiler-warnings.m4 I see that =yes adds a bunch of -Wblah options to CFLAGS, so I instead changed it to =no and added a comment why. Committed with that fixed, thanks.
diff --git a/package/libqmi/libqmi.mk b/package/libqmi/libqmi.mk index 911b1a7..8bd4577 100644 --- a/package/libqmi/libqmi.mk +++ b/package/libqmi/libqmi.mk @@ -13,4 +13,6 @@ LIBQMI_INSTALL_STAGING = YES LIBQMI_DEPENDENCIES = libglib2 +LIBQMI_CONF_OPT = --enable-more-warnings=yes + $(eval $(autotools-package))