| Message ID | CA+4CFy5WsC42Zwd7XwF+H=4eG_iEtfg9j5qdK3j7YfDNJtdOcA@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On 11/04/13 12:07, Wei Mi wrote: > Hi, > > This is to fix testcase error reported in PR58985. > > The intention of the testcase was to ensure there was no REG_EQUIV > notes generated for a reg which was used in a paradoxical subreg. When > target was x86, there was subreg generated so I omitted to add the > subreg in the regexp pattern. However there is no subreg generated for > target cris-axis-elf, so REG_EQUIV should be allowed. > > Is it ok for trunk and gcc-4.8 branch? > > Thanks, > Wei Mi. > > 2013-11-04 Wei Mi <wmi@google.com> > > PR regression/58985 > * testsuite/gcc.dg/pr57518.c: Add subreg in regexp pattern. Fine for the trunk. Release manager's call for the branch. jeff
+Release manager. Thanks, committed to trunk as r204438. Ok for 4.8 branch? On Tue, Nov 5, 2013 at 11:19 AM, Jeff Law <law@redhat.com> wrote: > On 11/04/13 12:07, Wei Mi wrote: >> >> Hi, >> >> This is to fix testcase error reported in PR58985. >> >> The intention of the testcase was to ensure there was no REG_EQUIV >> notes generated for a reg which was used in a paradoxical subreg. When >> target was x86, there was subreg generated so I omitted to add the >> subreg in the regexp pattern. However there is no subreg generated for >> target cris-axis-elf, so REG_EQUIV should be allowed. >> >> Is it ok for trunk and gcc-4.8 branch? >> >> Thanks, >> Wei Mi. >> >> 2013-11-04 Wei Mi <wmi@google.com> >> >> PR regression/58985 >> * testsuite/gcc.dg/pr57518.c: Add subreg in regexp pattern. > > Fine for the trunk. Release manager's call for the branch. > > jeff >
On Wed, Nov 6, 2013 at 3:51 AM, Wei Mi <wmi@google.com> wrote: > +Release manager. > > Thanks, committed to trunk as r204438. Ok for 4.8 branch? Ok. > On Tue, Nov 5, 2013 at 11:19 AM, Jeff Law <law@redhat.com> wrote: >> On 11/04/13 12:07, Wei Mi wrote: >>> >>> Hi, >>> >>> This is to fix testcase error reported in PR58985. >>> >>> The intention of the testcase was to ensure there was no REG_EQUIV >>> notes generated for a reg which was used in a paradoxical subreg. When >>> target was x86, there was subreg generated so I omitted to add the >>> subreg in the regexp pattern. However there is no subreg generated for >>> target cris-axis-elf, so REG_EQUIV should be allowed. >>> >>> Is it ok for trunk and gcc-4.8 branch? >>> >>> Thanks, >>> Wei Mi. >>> >>> 2013-11-04 Wei Mi <wmi@google.com> >>> >>> PR regression/58985 >>> * testsuite/gcc.dg/pr57518.c: Add subreg in regexp pattern. >> >> Fine for the trunk. Release manager's call for the branch. >> >> jeff >>
Index: testsuite/gcc.dg/pr57518.c =================================================================== --- testsuite/gcc.dg/pr57518.c (revision 204353) +++ testsuite/gcc.dg/pr57518.c (working copy) @@ -2,7 +2,7 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fdump-rtl-ira" } */ -/* { dg-final { scan-rtl-dump-not "REG_EQUIV\[^\n\]*mem\[^\n\]*\"ip\"" "ira" } } */ +/* { dg-final { scan-rtl-dump-not "REG_EQUIV\[^\n\]*mem\[^\n\]*\"ip\".*subreg" "ira" } } */
Hi, This is to fix testcase error reported in PR58985. The intention of the testcase was to ensure there was no REG_EQUIV notes generated for a reg which was used in a paradoxical subreg. When target was x86, there was subreg generated so I omitted to add the subreg in the regexp pattern. However there is no subreg generated for target cris-axis-elf, so REG_EQUIV should be allowed. Is it ok for trunk and gcc-4.8 branch? Thanks, Wei Mi. 2013-11-04 Wei Mi <wmi@google.com> PR regression/58985 * testsuite/gcc.dg/pr57518.c: Add subreg in regexp pattern. char ip[10]; int total;