diff mbox

[U-Boot,1/2] ARM: bcm2835: add missing mbox overscan response field

Message ID 1382473641-20614-1-git-send-email-a.heider@gmail.com
State Accepted
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Andre Heider Oct. 22, 2013, 8:27 p.m. UTC
Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

Signed-off-by: Andre Heider <a.heider@gmail.com>
---
 arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Warren Oct. 23, 2013, 4:54 p.m. UTC | #1
On 10/22/2013 09:27 PM, Andre Heider wrote:
> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.

This one patch,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>

You need to send/cc this patch to Albert Aribauld, since he applies ARM
patches. Or, perhaps just make sure the patch gets assigned to him in
patchwork?
Andre Heider Oct. 23, 2013, 7:46 p.m. UTC | #2
On Wed, Oct 23, 2013 at 05:54:13PM +0100, Stephen Warren wrote:
> On 10/22/2013 09:27 PM, Andre Heider wrote:
> > Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> 
> This one patch,
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> 
> You need to send/cc this patch to Albert Aribauld, since he applies ARM
> patches. Or, perhaps just make sure the patch gets assigned to him in
> patchwork?

Okay, I did the patchwork dance :)

Thanks,
Andre
Albert ARIBAUD Nov. 7, 2013, 1:29 p.m. UTC | #3
Hi Andre,

On Wed, 23 Oct 2013 21:46:31 +0200, Andre Heider <a.heider@gmail.com>
wrote:

> On Wed, Oct 23, 2013 at 05:54:13PM +0100, Stephen Warren wrote:
> > On 10/22/2013 09:27 PM, Andre Heider wrote:
> > > Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> > 
> > This one patch,
> > Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> > 
> > You need to send/cc this patch to Albert Aribauld, since he applies ARM
> > patches. Or, perhaps just make sure the patch gets assigned to him in
> > patchwork?
> 
> Okay, I did the patchwork dance :)
> 
> Thanks,
> Andre

In fact, the series could be applied as a whole by the same custodian
-- and actually, I'd prefer it to be applied as a whole, since patch 1/2
alone looks like dead/useless code, whereas it makes sense if applied
along with 2/2.

Amicalement,
Stephen Warren Nov. 7, 2013, 9:30 p.m. UTC | #4
On 11/07/2013 06:29 AM, Albert ARIBAUD wrote:
> Hi Andre,
> 
> On Wed, 23 Oct 2013 21:46:31 +0200, Andre Heider <a.heider@gmail.com>
> wrote:
> 
>> On Wed, Oct 23, 2013 at 05:54:13PM +0100, Stephen Warren wrote:
>>> On 10/22/2013 09:27 PM, Andre Heider wrote:
>>>> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
>>>
>>> This one patch,
>>> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>>>
>>> You need to send/cc this patch to Albert Aribauld, since he applies ARM
>>> patches. Or, perhaps just make sure the patch gets assigned to him in
>>> patchwork?
>>
>> Okay, I did the patchwork dance :)
>>
>> Thanks,
>> Andre
> 
> In fact, the series could be applied as a whole by the same custodian
> -- and actually, I'd prefer it to be applied as a whole, since patch 1/2
> alone looks like dead/useless code, whereas it makes sense if applied
> along with 2/2.

So, there are 2 patches and 2 custodians. One of you has to ack the
patch for the other to merge them both through the other's subsystem,
right? I guess you want Anatolij to take both of these through the video
tree based on your comments. If so, can you ack this patch and re-assign
them both in patchwork, so he knows that?
Albert ARIBAUD Nov. 8, 2013, 12:13 p.m. UTC | #5
Hi Andre,

On Tue, 22 Oct 2013 22:27:20 +0200, Andre Heider <a.heider@gmail.com>
wrote:

> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> 
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
>  arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/include/asm/arch-bcm2835/mbox.h b/arch/arm/include/asm/arch-bcm2835/mbox.h
> index 24abe57..6b806ec 100644
> --- a/arch/arm/include/asm/arch-bcm2835/mbox.h
> +++ b/arch/arm/include/asm/arch-bcm2835/mbox.h
> @@ -350,6 +350,7 @@ struct bcm2835_mbox_tag_overscan {
>  			u32 top;
>  			u32 bottom;
>  			u32 left;
> +			u32 right;
>  		} resp;
>  	} body;
>  };

Acked-by: Albert ARIBAUD <albert.u.boot@aribaud.net>

Amicalement,
Albert ARIBAUD Nov. 8, 2013, 12:16 p.m. UTC | #6
Hi Stephen,

On Thu, 07 Nov 2013 14:30:54 -0700, Stephen Warren
<swarren@wwwdotorg.org> wrote:

> So, there are 2 patches and 2 custodians. One of you has to ack the
> patch for the other to merge them both through the other's subsystem,
> right? I guess you want Anatolij to take both of these through the video
> tree based on your comments. If so, can you ack this patch and re-assign
> them both in patchwork, so he knows that?

Done (although I suspect that in this instance, my Ack was not really
needed, as the change was quite trivial and did not require any ARM-
specific knowledge).

Amicalement,
Anatolij Gustschin Nov. 9, 2013, 10:11 a.m. UTC | #7
On Tue, 22 Oct 2013 22:27:20 +0200
Andre Heider <a.heider@gmail.com> wrote:

> Add the missing "right" field to struct bcm2835_mbox_tag_overscan.
> 
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
>  arch/arm/include/asm/arch-bcm2835/mbox.h | 1 +
>  1 file changed, 1 insertion(+)

applied to u-boot-video/master, thanks!

Anatolij
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-bcm2835/mbox.h b/arch/arm/include/asm/arch-bcm2835/mbox.h
index 24abe57..6b806ec 100644
--- a/arch/arm/include/asm/arch-bcm2835/mbox.h
+++ b/arch/arm/include/asm/arch-bcm2835/mbox.h
@@ -350,6 +350,7 @@  struct bcm2835_mbox_tag_overscan {
 			u32 top;
 			u32 bottom;
 			u32 left;
+			u32 right;
 		} resp;
 	} body;
 };