| Message ID | 1381995462-32556-3-git-send-email-yamada.m@jp.panasonic.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Masahiro, On Thu, 17 Oct 2013 16:37:41 +0900, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote: > Commit 27af930e changed the boards.cfg format but > missed to change get_target_arch() fuction. > This commit adjusts it for CROSS_COMPILE_<ARCH> > to work correctly. > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > Cc: Albert ARIBAUD <albert.u.boot@aribaud.net> > --- > MAKEALL | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAKEALL b/MAKEALL > index 0d7893b..4f685e1 100755 > --- a/MAKEALL > +++ b/MAKEALL > @@ -571,7 +571,7 @@ get_target_arch() { > local target=$1 > > # Automatic mode > - local line=`egrep -i "^[[:space:]]*${target}[[:space:]]" boards.cfg` > + local line=`awk '\$7 == "'"$target"'" { print \$0 }' boards.cfg` > > if [ -z "${line}" ] ; then echo "" ; return ; fi > What issue does this change fix? Amicalement,
Hello Albert.
> What issue does this change fix?
MAKEALL supports the environment variable CROSS_COMPILE_<ARCH>.
MAKEALL --help says like follows:
CROSS_COMPILE_<ARCH> cross-compiler toolchain prefix for
architecture "ARCH". Substitute "ARCH" for any
This feature is useful when you want to build
various architectures at a time.
For example, you can use it like this:
CROSS_COMPILE_ARM=arm-linux-gnueabi- \
CROSS_COMPILE_POWERPC=powerpc-linux-gnu- \
CROSS_COMPILE_SH=sh4-linux- \
./MAKEALL -a arm -a powerpc -a sh
Commit 27af930e broke this feature,
so I want to fix this.
Best Regards
Masahiro Yamada
Hi Masahiro, On Thu, 17 Oct 2013 17:48:50 +0900, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote: > Hello Albert. > > > > > What issue does this change fix? > > > MAKEALL supports the environment variable CROSS_COMPILE_<ARCH>. > Commit 27af930e broke this feature, > so I want to fix this. Sorry, I have been unclear. How exactly does the commit break this feature? What worked before it which does not work after? > Best Regards > Masahiro Yamada Amicalement,
Hello Albert > > Commit 27af930e broke this feature, > > so I want to fix this. > > Sorry, I have been unclear. How exactly does the commit break this > feature? What worked before it which does not work after? A quite simple test. $ git checkout 27af930e^ $ CROSS_COMPILE_ARM=arm-linux-gnueabi- ./MAKEALL -a arm Configuring for integratorcp_cm1136 - Board: integratorcp, Options: CM1136 text data bss dec hex filename 160402 6164 16156 182722 2c9c2 ./u-boot Configuring for imx31_phycore board... text data bss dec hex filename 144449 5162 21016 170627 29a83 ./u-boot ... $ git checkout 27af930e $ CROSS_COMPILE_ARM=arm-linux-gnueabi- ./MAKEALL -a arm Configuring for integratorcp_cm1136 - Board: integratorcp, Options: CM1136 make: *** [lib/asm-offsets.s] Error 127 size: './u-boot': No such file /bin/bash: arm-linux-gcc: command not found /bin/bash: arm-linux-gcc: command not found dirname: missing operand Try 'dirname --help' for more information. /bin/bash: line 3: arm-linux-gcc: command not found /bin/bash: line 3: arm-linux-gcc: command not found /bin/bash: arm-linux-gcc: command not found /bin/bash: arm-linux-gcc: command not found ... Note: I am using arm-linux-gnueabi-gcc, not arm-linux-gcc Best Regards Masahiro Yamada
diff --git a/MAKEALL b/MAKEALL index 0d7893b..4f685e1 100755 --- a/MAKEALL +++ b/MAKEALL @@ -571,7 +571,7 @@ get_target_arch() { local target=$1 # Automatic mode - local line=`egrep -i "^[[:space:]]*${target}[[:space:]]" boards.cfg` + local line=`awk '\$7 == "'"$target"'" { print \$0 }' boards.cfg` if [ -z "${line}" ] ; then echo "" ; return ; fi
Commit 27af930e changed the boards.cfg format but missed to change get_target_arch() fuction. This commit adjusts it for CROSS_COMPILE_<ARCH> to work correctly. Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net> --- MAKEALL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)