| Message ID | 525B1722.5060001@samsung.com |
|---|---|
| State | New |
| Headers | show |
Hi, On Sun, Oct 13, 2013 at 2:56 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Alexander Shiyan (1): > ARM: SAMSUNG: Fix switching FIFO in arch_enable_uart_fifo function What's the regression that this is fixing? As far as I can tell, the code has been the same since 2008. Or did something surrounding it change? > > Bartlomiej Zolnierkiewicz (1): > ARM: dts: fix PL330 MDMA1 address in DT for Universal C210 board > > Jingoo Han (1): > ARM: dts: Remove DP PHY node from exynos5250.dtsi You are sending this in pretty late. Please be careful about conflicts due to this late revert, in particular if you plan on re-introducing something in 3.13. > Tomasz Figa (1): > ARM: dts: Work around lack of cpufreq regulator lookup for > exynos4210-origen and trats boards > > Youngmin Nam (1): > ARM: dts: Fix a typo on Exynos5440 DTS files This is a bad patch subject, it can be way more specific. Also, this is a good reason not to have these elaborate bootargs in the DTS, in particular for modern platforms -- the bootargs should come from firmware for your platform. -Olof
Olof Johansson wrote: > > Hi, > Hi, > On Sun, Oct 13, 2013 at 2:56 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > > Alexander Shiyan (1): > > ARM: SAMSUNG: Fix switching FIFO in arch_enable_uart_fifo function > > What's the regression that this is fixing? As far as I can tell, the > code has been the same since 2008. Or did something surrounding it > change? > Yeah, you're right. Actually I has queued it into non-critical before but missed to sent out. OK, I agree with you and let me sort out again. > > > > Bartlomiej Zolnierkiewicz (1): > > ARM: dts: fix PL330 MDMA1 address in DT for Universal C210 board > > > > Jingoo Han (1): > > ARM: dts: Remove DP PHY node from exynos5250.dtsi > > You are sending this in pretty late. Please be careful about conflicts > due to this late revert, in particular if you plan on re-introducing > something in 3.13. > As you know, unfortunately, DP PHY node change applied in DTS without changing driver in 3.12 so current 3.12 kernel cannot support it. I want 3.12 kernel to support it properly and yes, I have a plan to re-introduce DP PHY node in 3.13. BTW if you have objection, maybe I will send it to stable 3.12 instead... > > Tomasz Figa (1): > > ARM: dts: Work around lack of cpufreq regulator lookup for > > exynos4210-origen and trats boards > > > > Youngmin Nam (1): > > ARM: dts: Fix a typo on Exynos5440 DTS files > > This is a bad patch subject, it can be way more specific. Also, this > is a good reason not to have these elaborate bootargs in the DTS, in > particular for modern platforms -- the bootargs should come from > firmware for your platform. > Agreed. The subject should be clear...Anyway current bootargs in DTS is wrong so I think, it should be fixed, I agree with you about bootargs though. Thanks, Kukjin
The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f: Linux 3.12-rc1 (2013-09-16 16:17:51 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-fixes-1 for you to fetch changes up to b7f8c479e112cc09422aac2bda923a86b381fcc0: ARM: dts: fix PL330 MDMA1 address in DT for Universal C210 board (2013-10-08 07:09:52 +0900) ---------------------------------------------------------------- Fixes for v3.12 - fix UART for switching FIFO - correct typo 'samsung,pin-drv' - correct typo 'earlyprintk' - remove DP PHY for supporting dptx-phy on exynos5250 - cpufreq regulator lookup for exynos4210-origen and trats - fix PL330 MDMA1 address for universal c210 board ---------------------------------------------------------------- Al Stone (1): ARM: dts: Correct typo in use of samsung,pin-drv for exynos5250 Alexander Shiyan (1): ARM: SAMSUNG: Fix switching FIFO in arch_enable_uart_fifo function Bartlomiej Zolnierkiewicz (1): ARM: dts: fix PL330 MDMA1 address in DT for Universal C210 board Jingoo Han (1): ARM: dts: Remove DP PHY node from exynos5250.dtsi Tomasz Figa (1): ARM: dts: Work around lack of cpufreq regulator lookup for exynos4210-origen and trats boards Youngmin Nam (1): ARM: dts: Fix a typo on Exynos5440 DTS files arch/arm/boot/dts/exynos4210-origen.dts | 7 +++- arch/arm/boot/dts/exynos4210-trats.dts | 7 +++- arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 +++ arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44 ++++++++++++------------- arch/arm/boot/dts/exynos5250.dtsi | 13 +++----- arch/arm/boot/dts/exynos5440-sd5v1.dts | 2 +- arch/arm/boot/dts/exynos5440-ssdk5440.dts | 2 +- arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++ 8 files changed, 47 insertions(+), 34 deletions(-)