diff mbox

[U-Boot] mx6: Fix use of improper value in enable_ipu_clock

Message ID 69b4c52c2f049e7def7dc9d4b668a8a90243d9c5.1379935205.git.p.aubert@staubli.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Pierre Aubert Sept. 23, 2013, 11:37 a.m. UTC 
The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
the CCGR3 register caused an undefined value for CG0.

Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
CC: Stefano Babic <sbabic@denx.de>
---
 arch/arm/cpu/armv7/mx6/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Eric Nelson Sept. 23, 2013, 5:15 p.m. UTC | #1 
On 09/23/2013 04:37 AM, Pierre Aubert wrote:
> The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
> the CCGR3 register caused an undefined value for CG0.
>
> Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
> CC: Stefano Babic <sbabic@denx.de>
> ---
>   arch/arm/cpu/armv7/mx6/clock.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index 7efb0d2..0f7bcbc 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -457,7 +457,7 @@ void enable_ipu_clock(void)
>   	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
>   	int reg;
>   	reg = readl(&mxc_ccm->CCGR3);
> -	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
> +	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
>   	writel(reg, &mxc_ccm->CCGR3);
>   }
>   /***************************************************/
>

Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>
Stefano Babic Sept. 27, 2013, 12:06 p.m. UTC | #2 
> On 09/23/2013 04:37 AM, Pierre Aubert wrote:
>> The value MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET that was used to initialize
>> the CCGR3 register caused an undefined value for CG0.
>>
>> Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
>> CC: Stefano Babic <sbabic@denx.de>
>> ---

Applied to u-boot-imx (fix), thanks!

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
index 7efb0d2..0f7bcbc 100644
--- a/arch/arm/cpu/armv7/mx6/clock.c
+++ b/arch/arm/cpu/armv7/mx6/clock.c
@@ -457,7 +457,7 @@  void enable_ipu_clock(void)
 	struct mxc_ccm_reg *mxc_ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
 	int reg;
 	reg = readl(&mxc_ccm->CCGR3);
-	reg |= MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET;
+	reg |= MXC_CCM_CCGR3_IPU1_IPU_MASK;
 	writel(reg, &mxc_ccm->CCGR3);
 }
 /***************************************************/