| Message ID | 1379508595-30252-1-git-send-email-treding@nvidia.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Thierry Reding <thierry.reding@gmail.com> Date: Wed, 18 Sep 2013 14:49:55 +0200 > The dump_eth_one() function is only used if DEBUG is enabled, so protect > it by a corresponding #ifdef DEBUG block. > > Signed-off-by: Thierry Reding <treding@nvidia.com> I would prefer that this function and the one call site is simply removed instead. This kind of thing can be provided via ethtool register dumps and therefore without all of the ugliness this ad-hoc stuff presents. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 18, 2013 at 12:38:53PM -0400, David Miller wrote: > From: Thierry Reding <thierry.reding@gmail.com> > Date: Wed, 18 Sep 2013 14:49:55 +0200 > > > The dump_eth_one() function is only used if DEBUG is enabled, so protect > > it by a corresponding #ifdef DEBUG block. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > I would prefer that this function and the one call site is simply > removed instead. > > This kind of thing can be provided via ethtool register dumps > and therefore without all of the ugliness this ad-hoc stuff > presents. I just noticed the warning during some test builds I was doing due to some unrelated patches and thought I'd clean it up along the way. I'll send a patch to remove the functionality completely if that's what you prefer, but I won't be able to reimplement it using ethtool. Perhaps someone with actual hardware can do that. Thierry
diff --git a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c index c4dbf98..a452d93 100644 --- a/drivers/net/ethernet/tundra/tsi108_eth.c +++ b/drivers/net/ethernet/tundra/tsi108_eth.c @@ -168,6 +168,7 @@ static struct platform_driver tsi_eth_driver = { static void tsi108_timed_checker(unsigned long dev_ptr); +#ifdef DEBUG static void dump_eth_one(struct net_device *dev) { struct tsi108_prv_data *data = netdev_priv(dev); @@ -192,6 +193,7 @@ static void dump_eth_one(struct net_device *dev) TSI_READ(TSI108_EC_RXESTAT), TSI_READ(TSI108_EC_RXERR), data->rxpending); } +#endif /* Synchronization is needed between the thread and up/down events. * Note that the PHY is accessed through the same registers for both
The dump_eth_one() function is only used if DEBUG is enabled, so protect it by a corresponding #ifdef DEBUG block. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/net/ethernet/tundra/tsi108_eth.c | 2 ++ 1 file changed, 2 insertions(+)