| Message ID | 522011A1.2080305@asianux.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
[[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote: > Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it > will no related irq and base address). Do you have an H83000 and really know that is true? I'm guessing no. Looking at the driver, it is kind of broken that it only assigns I/O and irq for two platforms, but the H8300 arch Kconfig.cpu only allows building a single platform in a given kernel anyway, so a dependency fix is probably acceptable here. Given that, what you really want to indicate is something like: Currently only H8300H_AKI3068NET and H8300H_H8MAX define default I/O base and IRQ values for the NE_H8300 driver. Hence builds for other H8300H platforms will fail as per below. Since H8300H does not support multi platform builds, we simply limit building the driver to those two platforms specifically. > > The release error: > > CC [M] drivers/net/hamradio/bpqether.o ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This file has nothing to do with the problem in question. [If you are going to do a "make -j30" in testing, then at least restart with -j1 to properly capture the error message.] Please update the commit log appropriately and resubmit. Paul. -- > drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev': > drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) > drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in > drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant > drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) > drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module': > drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) > drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) > drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > drivers/net/ethernet/8390/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig > index a5f91e1..becef25 100644 > --- a/drivers/net/ethernet/8390/Kconfig > +++ b/drivers/net/ethernet/8390/Kconfig > @@ -148,7 +148,7 @@ config PCMCIA_PCNET > > config NE_H8300 > tristate "NE2000 compatible support for H8/300" > - depends on H8300 > + depends on H8300H_AKI3068NET || H8300H_H8MAX > ---help--- > Say Y here if you want to use the NE2000 compatible > controller on the Renesas H8/300 processor. > -- > 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/30/2013 10:36 PM, Paul Gortmaker wrote: > [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote: > >> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it >> will no related irq and base address). > > Do you have an H83000 and really know that is true? I'm guessing no. > > Looking at the driver, it is kind of broken that it only assigns I/O and > irq for two platforms, but the H8300 arch Kconfig.cpu only allows building > a single platform in a given kernel anyway, so a dependency fix is > probably acceptable here. > OK, thanks. > Given that, what you really want to indicate is something like: > > Currently only H8300H_AKI3068NET and H8300H_H8MAX define default > I/O base and IRQ values for the NE_H8300 driver. Hence builds > for other H8300H platforms will fail as per below. Since H8300H > does not support multi platform builds, we simply limit building > the driver to those two platforms specifically. > Hmm... that sounds good to me. >> >> The release error: >> >> CC [M] drivers/net/hamradio/bpqether.o > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > This file has nothing to do with the problem in question. [If you are > going to do a "make -j30" in testing, then at least restart with -j1 to > properly capture the error message.] > Oh, it is a waste, which I should remove, thanks. > Please update the commit log appropriately and resubmit. > OK, I will send patch v2. > Paul. > -- > >> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev': >> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) >> drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in >> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant >> drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) >> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module': >> drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) >> drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) >> drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] >> >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> --- >> drivers/net/ethernet/8390/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig >> index a5f91e1..becef25 100644 >> --- a/drivers/net/ethernet/8390/Kconfig >> +++ b/drivers/net/ethernet/8390/Kconfig >> @@ -148,7 +148,7 @@ config PCMCIA_PCNET >> >> config NE_H8300 >> tristate "NE2000 compatible support for H8/300" >> - depends on H8300 >> + depends on H8300H_AKI3068NET || H8300H_H8MAX >> ---help--- >> Say Y here if you want to use the NE2000 compatible >> controller on the Renesas H8/300 processor. >> -- >> 1.7.7.6 > > Thanks.
On 09/02/2013 09:48 AM, Chen Gang wrote: > On 08/30/2013 10:36 PM, Paul Gortmaker wrote: >> [[PATCH] drivers: net: ethernet: 8390: Kconfig: add H8300H_AKI3068NET and H8300H_H8MAX dependancy for NE_H8300] On 30/08/2013 (Fri 11:29) Chen Gang wrote: >> >>> Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it >>> will no related irq and base address). >> >> Do you have an H83000 and really know that is true? I'm guessing no. Oh, sorry, forgot reply this item. And I have no related hardware (I am just cross compiling). Hmm... according to the implementation, we can assume original author though: "currently only H8300H_AKI3068NET and H8300H_H8MAX can/need support NE_H8300" (may better use "need" instead of "can"). Thanks. >> >> Looking at the driver, it is kind of broken that it only assigns I/O and >> irq for two platforms, but the H8300 arch Kconfig.cpu only allows building >> a single platform in a given kernel anyway, so a dependency fix is >> probably acceptable here. >> > > OK, thanks. > >> Given that, what you really want to indicate is something like: >> >> Currently only H8300H_AKI3068NET and H8300H_H8MAX define default >> I/O base and IRQ values for the NE_H8300 driver. Hence builds >> for other H8300H platforms will fail as per below. Since H8300H >> does not support multi platform builds, we simply limit building >> the driver to those two platforms specifically. >> > > Hmm... that sounds good to me. > >>> >>> The release error: >>> >>> CC [M] drivers/net/hamradio/bpqether.o >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> This file has nothing to do with the problem in question. [If you are >> going to do a "make -j30" in testing, then at least restart with -j1 to >> properly capture the error message.] >> > > Oh, it is a waste, which I should remove, thanks. > > >> Please update the commit log appropriately and resubmit. >> > > OK, I will send patch v2. > >> Paul. >> -- >> >>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev': >>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) >>> drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in >>> drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant >>> drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) >>> drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module': >>> drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) >>> drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) >>> drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] >>> >>> >>> Signed-off-by: Chen Gang <gang.chen@asianux.com> >>> --- >>> drivers/net/ethernet/8390/Kconfig | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig >>> index a5f91e1..becef25 100644 >>> --- a/drivers/net/ethernet/8390/Kconfig >>> +++ b/drivers/net/ethernet/8390/Kconfig >>> @@ -148,7 +148,7 @@ config PCMCIA_PCNET >>> >>> config NE_H8300 >>> tristate "NE2000 compatible support for H8/300" >>> - depends on H8300 >>> + depends on H8300H_AKI3068NET || H8300H_H8MAX >>> ---help--- >>> Say Y here if you want to use the NE2000 compatible >>> controller on the Renesas H8/300 processor. >>> -- >>> 1.7.7.6 >> >> > > Thanks. >
diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig index a5f91e1..becef25 100644 --- a/drivers/net/ethernet/8390/Kconfig +++ b/drivers/net/ethernet/8390/Kconfig @@ -148,7 +148,7 @@ config PCMCIA_PCNET config NE_H8300 tristate "NE2000 compatible support for H8/300" - depends on H8300 + depends on H8300H_AKI3068NET || H8300H_H8MAX ---help--- Say Y here if you want to use the NE2000 compatible controller on the Renesas H8/300 processor.
Only H8300H_AKI3068NET and H8300H_H8MAX can support NE_H8300 (or it will no related irq and base address). The release error: CC [M] drivers/net/hamradio/bpqether.o drivers/net/ethernet/8390/ne-h8300.c: In function 'init_dev': drivers/net/ethernet/8390/ne-h8300.c:117:23: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:117:23: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/8390/ne-h8300.c:117:23: error: bit-field '<anonymous>' width not an integer constant drivers/net/ethernet/8390/ne-h8300.c:119:20: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c: In function 'init_module': drivers/net/ethernet/8390/ne-h8300.c:647:21: error: 'h8300_ne_base' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:648:15: error: 'h8300_ne_irq' undeclared (first use in this function) drivers/net/ethernet/8390/ne-h8300.c:661:4: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] Signed-off-by: Chen Gang <gang.chen@asianux.com> --- drivers/net/ethernet/8390/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)