Message ID | 18365346.kxAWDne41Q@al |
---|---|
State | Superseded, archived |
Headers | show |
Peter Wu <lekensteyn@gmail.com> : [...] > Please find the updated patch below. There may be differences in lines > because net-next has the r8169,sis190 patch and net the WOL fix. > > Can I consider Francois reply[1] as Acked-by? Yes, provided you insert an empty line between declarations and code. You may / should send patches as normal submissions. It will probably be easier for davem to use and you can always raise questions or add minor remarks in the "--- ... diff" section.
On Wednesday 21 August 2013 22:53:25 Francois Romieu wrote: > Peter Wu <lekensteyn@gmail.com> : > [...] > > > Please find the updated patch below. There may be differences in lines > > because net-next has the r8169,sis190 patch and net the WOL fix. > > > > Can I consider Francois reply[1] as Acked-by? > > Yes, provided you insert an empty line between declarations and code. Done, new patch will arrive in a minute. > You may / should send patches as normal submissions. It will probably > be easier for davem to use and you can always raise questions or add > minor remarks in the "--- ... diff" section. I noticed that patchwork also recognized submissions that are appended to a mail, so I tried that out ;-) Well, apparantly it does not work well with git, so I will just send a new patch with a useful In-Reply-To header. Peter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 93ee49d..f724d9c 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -1897,9 +1897,12 @@ static void rtl8169_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p) { struct rtl8169_private *tp = netdev_priv(dev); - + u32 __iomem *data = tp->mmio_addr; + u32 *dw = p; + int i; rtl_lock_work(tp); - memcpy_fromio(p, tp->mmio_addr, regs->len); + for (i = 0; i < R8169_REGS_SIZE; i += 4) + memcpy_fromio(dw++, data++, 4); rtl_unlock_work(tp); }