Message ID | 49C8E7FF.7020906@cosmosbay.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
Eric Dumazet wrote: > You probably have the problem Ingo reported on lkml, please try Herbert > fix : > > http://marc.info/?l=linux-kernel&m=123790184128396&w=2 yes this patch fix the problem. Thanks Eric and thanks Herbert. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Marco Berizzi wrote: > Eric Dumazet wrote: > > > You probably have the problem Ingo reported on lkml, please try Herbert > > fix : > > > > http://marc.info/?l=linux-kernel&m=123790184128396&w=2 > > yes this patch fix the problem. > Thanks Eric and thanks Herbert. no, it doesn't fix the problem. This morning I got the same problem (I was reading the kernel mailing list on lkml.indiana.edu with firefox) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 25, 2009 at 09:10:29AM +0100, Marco Berizzi wrote: > > no, it doesn't fix the problem. > This morning I got the same problem > (I was reading the kernel mailing list > on lkml.indiana.edu with firefox) Please try the full GRO revert for netif_rx that I just posted. Thanks,
Herbert Xu wrote: > On Wed, Mar 25, 2009 at 09:10:29AM +0100, Marco Berizzi wrote: > > > > no, it doesn't fix the problem. > > This morning I got the same problem > > (I was reading the kernel mailing list > > on lkml.indiana.edu with firefox) > > Please try the full GRO revert for netif_rx that I just posted. ok, I have reverted the GRO and I have not got the problem. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index e3fe5c7..523f53e 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2580,24 +2580,26 @@ static int process_backlog(struct napi_struct *napi, int quota) int work = 0; struct softnet_data *queue = &__get_cpu_var(softnet_data); unsigned long start_time = jiffies; + struct sk_buff *skb; napi->weight = weight_p; do { - struct sk_buff *skb; - local_irq_disable(); skb = __skb_dequeue(&queue->input_pkt_queue); - if (!skb) { - local_irq_enable(); - napi_complete(napi); - goto out; - } local_irq_enable(); + if (!skb) + break; napi_gro_receive(napi, skb); } while (++work < quota && jiffies == start_time); napi_gro_flush(napi); + if (skb) + goto out; + + local_irq_disable(); + __napi_complete(napi); + local_irq_enable(); out: return work;