| Message ID | 49C3515D.7090703@cn.fujitsu.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Yang Hongyang <yanghy@cn.fujitsu.com> Date: Fri, 20 Mar 2009 16:18:37 +0800 > Do not need '&' in the init of function pointers. > > Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> It's harmless, just leave it alone. This is just going to be commit noise. More useful would be to convert this driver over to net_device_ops. I'm not applying this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller wrote: > From: Yang Hongyang <yanghy@cn.fujitsu.com> > Date: Fri, 20 Mar 2009 16:18:37 +0800 > >> Do not need '&' in the init of function pointers. >> >> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> > > It's harmless, just leave it alone. This is just going to be commit > noise. OK. > > More useful would be to convert this driver over to net_device_ops. > > I'm not applying this. > >
David Miller wrote: > From: Yang Hongyang <yanghy@cn.fujitsu.com> > Date: Fri, 20 Mar 2009 16:18:37 +0800 > >> Do not need '&' in the init of function pointers. >> >> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> > > It's harmless, just leave it alone. This is just going to be commit > noise. > > More useful would be to convert this driver over to net_device_ops. I'll do that. > > I'm not applying this. > >
diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c index 88d2c67..247fe9b 100644 --- a/drivers/net/spider_net.c +++ b/drivers/net/spider_net.c @@ -2268,20 +2268,20 @@ spider_net_tx_timeout(struct net_device *netdev) static void spider_net_setup_netdev_ops(struct net_device *netdev) { - netdev->open = &spider_net_open; - netdev->stop = &spider_net_stop; - netdev->hard_start_xmit = &spider_net_xmit; - netdev->set_multicast_list = &spider_net_set_multi; - netdev->set_mac_address = &spider_net_set_mac; - netdev->change_mtu = &spider_net_change_mtu; - netdev->do_ioctl = &spider_net_do_ioctl; + netdev->open = spider_net_open; + netdev->stop = spider_net_stop; + netdev->hard_start_xmit = spider_net_xmit; + netdev->set_multicast_list = spider_net_set_multi; + netdev->set_mac_address = spider_net_set_mac; + netdev->change_mtu = spider_net_change_mtu; + netdev->do_ioctl = spider_net_do_ioctl; /* tx watchdog */ - netdev->tx_timeout = &spider_net_tx_timeout; + netdev->tx_timeout = spider_net_tx_timeout; netdev->watchdog_timeo = SPIDER_NET_WATCHDOG_TIMEOUT; /* HW VLAN */ #ifdef CONFIG_NET_POLL_CONTROLLER /* poll controller */ - netdev->poll_controller = &spider_net_poll_controller; + netdev->poll_controller = spider_net_poll_controller; #endif /* CONFIG_NET_POLL_CONTROLLER */ /* ethtool ops */ netdev->ethtool_ops = &spider_net_ethtool_ops;
Do not need '&' in the init of function pointers. Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> --- drivers/net/spider_net.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)