Message ID | 7629c2a65cffd7b61d100703567e027a2850c3c6.1371200138.git.yamahata@valinux.co.jp |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, Jun 14, 2013 at 05:58:33PM +0900, Isaku Yamahata wrote: > The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t" > converted skb->end from pointer to sk_buff_data_t. > The pointed value should be accessed via skb_end_pointer(). > > Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET, > skb->end is effectively pointer. So it doesn't cause a real problem. > But this patch is good for consistency. > > Found by inspection. Compile test only. > > Cc: Simon Horman <horms@verge.net.au> > Cc: Lennert Buytenhek <buytenh@wantstofly.org> > Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Reviewed-by: Simon Horman <horms@verge.net.au> > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c > index c7f9fb3..510d506 100644 > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c > @@ -621,7 +621,7 @@ static int rxq_refill(struct rx_queue *rxq, int budget) > > rx_desc = rxq->rx_desc_area + rx; > > - size = skb->end - skb->data; > + size = skb_end_pointer(skb) - skb->data; > rx_desc->buf_ptr = dma_map_single(mp->dev->dev.parent, > skb->data, size, > DMA_FROM_DEVICE); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Simon Horman <horms@verge.net.au> Date: Mon, 17 Jun 2013 11:02:18 +0900 > On Fri, Jun 14, 2013 at 05:58:33PM +0900, Isaku Yamahata wrote: >> The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t" >> converted skb->end from pointer to sk_buff_data_t. >> The pointed value should be accessed via skb_end_pointer(). >> >> Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET, >> skb->end is effectively pointer. So it doesn't cause a real problem. >> But this patch is good for consistency. >> >> Found by inspection. Compile test only. >> >> Cc: Simon Horman <horms@verge.net.au> >> Cc: Lennert Buytenhek <buytenh@wantstofly.org> >> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> > > Reviewed-by: Simon Horman <horms@verge.net.au> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index c7f9fb3..510d506 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -621,7 +621,7 @@ static int rxq_refill(struct rx_queue *rxq, int budget) rx_desc = rxq->rx_desc_area + rx; - size = skb->end - skb->data; + size = skb_end_pointer(skb) - skb->data; rx_desc->buf_ptr = dma_map_single(mp->dev->dev.parent, skb->data, size, DMA_FROM_DEVICE);
The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t" converted skb->end from pointer to sk_buff_data_t. The pointed value should be accessed via skb_end_pointer(). Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET, skb->end is effectively pointer. So it doesn't cause a real problem. But this patch is good for consistency. Found by inspection. Compile test only. Cc: Simon Horman <horms@verge.net.au> Cc: Lennert Buytenhek <buytenh@wantstofly.org> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> --- drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)