| Message ID | 1368205337-4624-2-git-send-email-rmody@brocade.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Rasesh Mody <rmody@brocade.com> Date: Fri, 10 May 2013 10:02:14 -0700 > Driver configuration flags are retained across open/stop operations > preventing configurations to be set in next open/stop. > Setting MTU on a 1020 causes network to fail until a reboot is performed > on the host. > > Clear the flags when configuration resets in hardware. Please stop indenting your commit messages like this, nobody else does this, so I cannot imagine where you observed this convention. Resubmit this patch series with this corrected, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index ce4a030..a6c16a2 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -2624,6 +2624,9 @@ bnad_stop(struct net_device *netdev) bnad_destroy_tx(bnad, 0); bnad_destroy_rx(bnad, 0); + /* These config flags are cleared in the hardware */ + bnad->cfg_flags &= ~(BNAD_CF_ALLMULTI | BNAD_CF_PROMISC); + /* Synchronize mailbox IRQ */ bnad_mbox_irq_sync(bnad);
Driver configuration flags are retained across open/stop operations preventing configurations to be set in next open/stop. Setting MTU on a 1020 causes network to fail until a reboot is performed on the host. Clear the flags when configuration resets in hardware. Signed-off-by: Rasesh Mody <rmody@brocade.com> --- drivers/net/ethernet/brocade/bna/bnad.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)