| Message ID | 1366279869-23387-7-git-send-email-nobuhiro.iwamatsu.yj@renesas.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 18-04-2013 14:11, Nobuhiro Iwamatsu wrote: > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> That's what I was going to do first. > drivers/net/ethernet/renesas/sh_eth.c | 4 ---- > 1 file changed, 4 deletions(-) > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index a4e337f..eb428d4 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -313,9 +313,6 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { > [TSU_ADRL31] = 0x01fc, > }; > > -#if defined(CONFIG_CPU_SUBTYPE_SH7734) || \ > - defined(CONFIG_CPU_SUBTYPE_SH7763) || \ > - defined(CONFIG_ARCH_R8A7740) > static void sh_eth_select_mii(struct net_device *ndev) Don't you want to annotate the function with __maybe_unused? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, (2013/04/18 23:36), Sergei Shtylyov wrote: > Hello. > > On 18-04-2013 14:11, Nobuhiro Iwamatsu wrote: > >> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> > > That's what I was going to do first. > >> drivers/net/ethernet/renesas/sh_eth.c | 4 ---- >> 1 file changed, 4 deletions(-) > >> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c >> index a4e337f..eb428d4 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -313,9 +313,6 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { >> [TSU_ADRL31] = 0x01fc, >> }; >> >> -#if defined(CONFIG_CPU_SUBTYPE_SH7734) || \ >> - defined(CONFIG_CPU_SUBTYPE_SH7763) || \ >> - defined(CONFIG_ARCH_R8A7740) >> static void sh_eth_select_mii(struct net_device *ndev) > > Don't you want to annotate the function with __maybe_unused? > I see. I will add __maybe_unused. thanks! Best regards, Nobuhiro -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index a4e337f..eb428d4 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -313,9 +313,6 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { [TSU_ADRL31] = 0x01fc, }; -#if defined(CONFIG_CPU_SUBTYPE_SH7734) || \ - defined(CONFIG_CPU_SUBTYPE_SH7763) || \ - defined(CONFIG_ARCH_R8A7740) static void sh_eth_select_mii(struct net_device *ndev) { u32 value = 0x0; @@ -339,7 +336,6 @@ static void sh_eth_select_mii(struct net_device *ndev) sh_eth_write(ndev, value, RMII_MII); } -#endif #if defined(CONFIG_CPU_SUBTYPE_SH7619) || \ defined(CONFIG_CPU_SUBTYPE_SH7710) || \
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> --- v2: no change. drivers/net/ethernet/renesas/sh_eth.c | 4 ---- 1 file changed, 4 deletions(-)