Message ID | 1366280825-31136-6-git-send-email-lee.jones@linaro.org |
---|---|
State | New |
Headers | show |
On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones <lee.jones@linaro.org> wrote: > Clearly this driver hasn't been tested, or even enabled in a while. > > drivers/crypto/ux500/cryp/cryp_core.c:1771:3: > error: request for member ‘pm’ in something not a structure or union > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: David S. Miller <davem@davemloft.net> > Cc: Andreas Westin <andreas.westin@stericsson.com> > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> NAK. I already fixed this. It is in v3.9-rc7. Yours, Linus Walleij
On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > Clearly this driver hasn't been tested, or even enabled in a while. > > > > drivers/crypto/ux500/cryp/cryp_core.c:1771:3: > > error: request for member ‘pm’ in something not a structure or union > > > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > Cc: David S. Miller <davem@davemloft.net> > > Cc: Andreas Westin <andreas.westin@stericsson.com> > > Cc: linux-crypto@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > NAK. I already fixed this. It is in v3.9-rc7. Yes, I saw it when I rebased. I've dropped the patch.
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c b/drivers/crypto/ux500/cryp/cryp_core.c index a56cbc4..444deaf 100644 --- a/drivers/crypto/ux500/cryp/cryp_core.c +++ b/drivers/crypto/ux500/cryp/cryp_core.c @@ -1750,7 +1750,7 @@ static struct platform_driver cryp_driver = { .shutdown = ux500_cryp_shutdown, .driver = { .owner = THIS_MODULE, - .name = "cryp1" + .name = "cryp1", .pm = &ux500_cryp_pm, } };
Clearly this driver hasn't been tested, or even enabled in a while. drivers/crypto/ux500/cryp/cryp_core.c:1771:3: error: request for member ‘pm’ in something not a structure or union Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: David S. Miller <davem@davemloft.net> Cc: Andreas Westin <andreas.westin@stericsson.com> Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/crypto/ux500/cryp/cryp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)