| Message ID | 5175F5C3.8060503@asianux.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Chen Gang <gang.chen@asianux.com> Date: Tue, 23 Apr 2013 10:45:23 +0800 > need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W. > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 > (by Pravin B Shelar <pshelar@nicira.com> Mon Mar 25 14:49:35 2013) > > Signed-off-by: Chen Gang <gang.chen@asianux.com> Do not put the destination GIT tree outside of the "[]" brackets. Put it inside the "[]" brackets, so it doesn't show up in the final commit message. Also, do not capitalize it, just "net-next" is fine. Putting "(by Pravin B Shelar <pshelar@nicira.com> Mon Mar 25 14:49:35 2013)" is not what we asked for, we asked for the commit message header line which for this commit would be ("GRE: Refactor GRE tunneling code.") I want to know by what example you are doing these things? Follow the model of other successful patch submitters, such as Eric Dumazet, Ben Hutchings, Thomas Graf, Simon Horman, etc. just to name a few. Do exactly what they do, because I never have to tell those people how to properly format their commit messages, header lines, and the patch itself. In your commit message body, properly capitalize your sentences. This feedback applies to all of the patches you have submitted. I'm sorry I have to pick you apart so much, but if you're going to contribute regularly you have to get this right, I can't be constantly fixing up by hand every patch you submit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013年04月23日 13:16, David Miller wrote: > From: Chen Gang <gang.chen@asianux.com> > Date: Tue, 23 Apr 2013 10:45:23 +0800 > >> > need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W. >> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 >> > (by Pravin B Shelar <pshelar@nicira.com> Mon Mar 25 14:49:35 2013) >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > Do not put the destination GIT tree outside of the "[]" brackets. Put > it inside the "[]" brackets, so it doesn't show up in the final commit > message. > ok, thanks. > Also, do not capitalize it, just "net-next" is fine. > ok, thanks. > Putting "(by Pravin B Shelar <pshelar@nicira.com> Mon Mar 25 14:49:35 2013)" > is not what we asked for, we asked for the commit message header line > which for this commit would be ("GRE: Refactor GRE tunneling code.") > ok, thanks. > I want to know by what example you are doing these things? Follow > the model of other successful patch submitters, such as Eric Dumazet, > Ben Hutchings, Thomas Graf, Simon Horman, etc. just to name a few. > > Do exactly what they do, because I never have to tell those people how > to properly format their commit messages, header lines, and the patch > itself. > ok, thanks. > In your commit message body, properly capitalize your sentences. > ok, thanks. > This feedback applies to all of the patches you have submitted. I'm > sorry I have to pick you apart so much, but if you're going to > contribute regularly you have to get this right, I can't be constantly > fixing up by hand every patch you submit. > > ok, thanks. need I send patch v3 ?
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 987a4e5..c625e4d 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb, if (dev->header_ops) { /* Need space for new headers */ if (skb_cow_head(skb, dev->needed_headroom - - (tunnel->hlen + sizeof(struct iphdr)))); + (tunnel->hlen + sizeof(struct iphdr)))) goto free_skb; tnl_params = (const struct iphdr *)skb->data;
need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W. the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 (by Pravin B Shelar <pshelar@nicira.com> Mon Mar 25 14:49:35 2013) Signed-off-by: Chen Gang <gang.chen@asianux.com> --- net/ipv4/ip_gre.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)