| Message ID | 51750E31.2010906@asianux.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 22-04-2013 14:17, Chen Gang wrote: > need remove erroneous semicolon. > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 You also need to specify that commit's summary line in parens. > Find it by EXTRA_CFLAGS=-W > Signed-off-by: Chen Gang <gang.chen@asianux.com> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Chen Gang <gang.chen@asianux.com> Date: Mon, 22 Apr 2013 18:17:21 +0800 > need remove erroneous semicolon. > > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 > > Find it by EXTRA_CFLAGS=-W > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> First, what is a "type issue", you aren't changing any variable or declaration types in this change. Second, your formatting of your commit messages is terrible. Do not indent the description with two spaces, just keep them at the leftmost column. Where did you learn to indent things like that, who else does that? If you've never seen it before, don't invent things. It is very irritating when we see people write commit messages with their own style rather than mimicking what other successful contributors are doing. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013年04月22日 22:32, Sergei Shtylyov wrote: > Hello. > > On 22-04-2013 14:17, Chen Gang wrote: > >> need remove erroneous semicolon. > >> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 > > You also need to specify that commit's summary line in parens. > ok, thanks, I will send patch v2. >> Find it by EXTRA_CFLAGS=-W > > >> Signed-off-by: Chen Gang <gang.chen@asianux.com> > > WBR, Sergei > > > >
On 2013年04月23日 03:44, David Miller wrote: > From: Chen Gang <gang.chen@asianux.com> > Date: Mon, 22 Apr 2013 18:17:21 +0800 > >> need remove erroneous semicolon. >> >> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 >> >> Find it by EXTRA_CFLAGS=-W >> >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> > > First, what is a "type issue", you aren't changing any variable > or declaration types in this change. > sorry for my poor English, maybe 'type issue' need change to 'typo issue' ? > Second, your formatting of your commit messages is terrible. > > Do not indent the description with two spaces, just keep them at the > leftmost column. Where did you learn to indent things like that, who > else does that? If you've never seen it before, don't invent things. > ok, excuse me, what I have done is only to try to make my expression is as clearer as I can. my English is not quite well, I am afraid to let other members can not understand or misunderstand what I write. but since you dislike it, I will not send messages like that to you. > It is very irritating when we see people write commit messages with > their own style rather than mimicking what other successful > contributors are doing. > sorry, I am not quite understand what your meaning. I guess your meaning is: "you are very angry to see a member write message with his own style. if a member is a successful contributor, he never writes message with his own style, he only follow the public standard style". is what I guess correct ? thanks. > Thanks. > >
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 987a4e5..c625e4d 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb, if (dev->header_ops) { /* Need space for new headers */ if (skb_cow_head(skb, dev->needed_headroom - - (tunnel->hlen + sizeof(struct iphdr)))); + (tunnel->hlen + sizeof(struct iphdr)))) goto free_skb; tnl_params = (const struct iphdr *)skb->data;
need remove erroneous semicolon. the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5 Find it by EXTRA_CFLAGS=-W Signed-off-by: Chen Gang <gang.chen@asianux.com> --- net/ipv4/ip_gre.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)