Message ID | 1365871134-6834-1-git-send-email-festevam@gmail.com |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show |
On Sat, 2013-04-13 at 13:38 -0300, Fabio Estevam wrote: > Currently when booting a mx6 device we get the following on boot: > registered PHC device on eth%d [] > diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c [] > @@ -380,6 +380,6 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev) > fep->ptp_clock = NULL; > pr_err("ptp_clock_register failed\n"); > } else { > - pr_info("registered PHC device on %s\n", ndev->name); > + pr_info("registered PHC device on eth%d\n", fep->dev_id); Maybe better as: netdev_info(ndev, "registered PHC device %d\n", fep->dev_id); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Apr 13, 2013 at 1:49 PM, Joe Perches <joe@perches.com> wrote: > Maybe better as: > netdev_info(ndev, "registered PHC device %d\n", fep->dev_id); In this case I get: fec 2188000.ethernet (unregistered net_device): registered PHC device 0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 2013-04-13 at 13:54 -0300, Fabio Estevam wrote: > On Sat, Apr 13, 2013 at 1:49 PM, Joe Perches <joe@perches.com> wrote: > > > Maybe better as: > > netdev_info(ndev, "registered PHC device %d\n", fep->dev_id); > > In this case I get: > > fec 2188000.ethernet (unregistered net_device): registered PHC device 0 Everything in fec_probe between the alloc_etherdev and register_netdev would get that, but the actual registered netdev name perhaps is not guaranteed to be fep->dev_id. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 1f17ca0..62e39fe 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -380,6 +380,6 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev) fep->ptp_clock = NULL; pr_err("ptp_clock_register failed\n"); } else { - pr_info("registered PHC device on %s\n", ndev->name); + pr_info("registered PHC device on eth%d\n", fep->dev_id); } }