Message ID | CACRpkdZM8+6QaGrRtCCMWoZQO23uej7JDr1xz2zG7TtwQ7Ngqw@mail.gmail.com |
---|---|
State | Not Applicable |
Headers | show |
On Tue, Jan 22, 2013 at 10:19:16AM +0100, Linus Walleij wrote: > Hi ARM SoC guys, > > This patch series converts the Nomadik to use Device Tree. > > Changes outside of the subsystem are constrained to pinctrl (my subsystem > and thus OK:ed) and a oneline in drivers/mtd/nand/fsmc_nand.c adding > a new compatible value. > > The MTD maintainers have had time enough to ACK that oneliner and it > shouldn't be a big issue, so: > > Please pull this into your tree. Hi, Sorry for a late feedback on this, but after merging, this doesn't seem to build due to lack of vic_of_init symbol visibility (i.e. it's exported out of drivers/irqchip/irq-vic.c, but it's not actually defined in any header file. Also, a couple of small merge conflicts with the timer and irq cleanup branches. Would you mind rebasing on top of the depends/cleanup branch in arm-soc, sort out the breakage (and test it) and resubmit? Thanks! -Olof
On Mon, Jan 28, 2013 at 10:31 PM, Olof Johansson <olof@lixom.net> wrote: > On Tue, Jan 22, 2013 at 10:19:16AM +0100, Linus Walleij wrote: >> Hi ARM SoC guys, >> >> This patch series converts the Nomadik to use Device Tree. >> >> Changes outside of the subsystem are constrained to pinctrl (my subsystem >> and thus OK:ed) and a oneline in drivers/mtd/nand/fsmc_nand.c adding >> a new compatible value. >> >> The MTD maintainers have had time enough to ACK that oneliner and it >> shouldn't be a big issue, so: >> >> Please pull this into your tree. > > Hi, > > Sorry for a late feedback on this, but after merging, this doesn't seem to > build due to lack of vic_of_init symbol visibility (i.e. it's exported out of > drivers/irqchip/irq-vic.c, but it's not actually defined in any header file. Hm? arch/arm/include/asm/hardware/vic.h int vic_of_init(struct device_node *node, struct device_node *parent); > Also, a couple of small merge conflicts with the timer and irq cleanup > branches. Do you think the above also comes from that branch? > Would you mind rebasing on top of the depends/cleanup branch in arm-soc, sort > out the breakage (and test it) and resubmit? I'll try! Yours, Linus Walleij