Message ID | 50EC79E1.1080802@freescale.com |
---|---|
State | Not Applicable |
Headers | show |
Dear York Sun, In message <50EC79E1.1080802@freescale.com> you wrote: > > No disagree. How shall we close this? Will some change like below > acceptable? > > diff --git a/include/linux/types.h b/include/linux/types.h > index 925ece7..f07ba41 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -7,6 +7,7 @@ > > #include <linux/posix_types.h> > #include <asm/types.h> > +#include <stdbool.h> Yes, but it needs to be tested that this is working for at least the most popular tool chains, including when using USE_PRIVATE_LIBGCC. > #ifndef __KERNEL_STRICT_NAMES > > @@ -113,10 +114,6 @@ typedef __u64 u_int64_t; > typedef __s64 int64_t; > #endif > > -typedef _Bool bool; > -#define false 0 > -#define true 1 > - Yes, but similar removals are needed in a nomber of other header files as well. Best regards, Wolfgang Denk
On 01/08/2013 01:39 PM, Wolfgang Denk wrote: > Dear York Sun, > > In message <50EC79E1.1080802@freescale.com> you wrote: >> >> No disagree. How shall we close this? Will some change like below >> acceptable? >> >> diff --git a/include/linux/types.h b/include/linux/types.h >> index 925ece7..f07ba41 100644 >> --- a/include/linux/types.h >> +++ b/include/linux/types.h >> @@ -7,6 +7,7 @@ >> >> #include <linux/posix_types.h> >> #include <asm/types.h> >> +#include <stdbool.h> > > Yes, but it needs to be tested that this is working for at least the > most popular tool chains, including when using USE_PRIVATE_LIBGCC. Who can help here? I don't have the setup for other than powerpc. > >> #ifndef __KERNEL_STRICT_NAMES >> >> @@ -113,10 +114,6 @@ typedef __u64 u_int64_t; >> typedef __s64 int64_t; >> #endif >> >> -typedef _Bool bool; >> -#define false 0 >> -#define true 1 >> - > > Yes, but similar removals are needed in a nomber of other header > files as well. > Yes. I have those in my local tree. York
On 01/08/2013 03:43:34 PM, York Sun wrote: > On 01/08/2013 01:39 PM, Wolfgang Denk wrote: > > Dear York Sun, > > > > In message <50EC79E1.1080802@freescale.com> you wrote: > >> > >> No disagree. How shall we close this? Will some change like below > >> acceptable? > >> > >> diff --git a/include/linux/types.h b/include/linux/types.h > >> index 925ece7..f07ba41 100644 > >> --- a/include/linux/types.h > >> +++ b/include/linux/types.h > >> @@ -7,6 +7,7 @@ > >> > >> #include <linux/posix_types.h> > >> #include <asm/types.h> > >> +#include <stdbool.h> > > > > Yes, but it needs to be tested that this is working for at least the > > most popular tool chains, including when using USE_PRIVATE_LIBGCC. > > Who can help here? I don't have the setup for other than powerpc. http://marc.info/?l=u-boot&m=132164771013203&w=1 -Scott
diff --git a/include/linux/types.h b/include/linux/types.h index 925ece7..f07ba41 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -7,6 +7,7 @@ #include <linux/posix_types.h> #include <asm/types.h> +#include <stdbool.h> #ifndef __KERNEL_STRICT_NAMES @@ -113,10 +114,6 @@ typedef __u64 u_int64_t; typedef __s64 int64_t; #endif -typedef _Bool bool; -#define false 0 -#define true 1 - #endif /* __KERNEL_STRICT_NAMES */ /*