Message ID | 1355423248-12448-1-git-send-email-florent.fourcot@enst-bretagne.fr |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On 12/13/2012 10:27 AM, Florent Fourcot wrote: > The double negation is probably a typo error > > Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr> > --- > net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > index 00ee17c..d9efe32 100644 > --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > @@ -81,7 +81,7 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff, > } > protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off); > /* > - * (protoff == skb->len) mean that the packet doesn't have no data > + * (protoff == skb->len) mean that the packet does not have any data > * except of IPv6 & ext headers. but it's tracked anyway. - YK > */ > if (protoff < 0 || (frag_off & htons(~0x7)) != 0) { > Might as well take it to completion and have it read "(protoff == skb->len) means the packet does not have any data" or "(protoff == skb->len) means the packet has no data" Not sure about that next line with the except. Perhaps "(protoff == skb->len) means the packet has no data, just IPv6 and extension headers, but it is tracked anyway." rick jones -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Perhaps "(protoff == skb->len) means the packet has no > data, just IPv6 and extension headers, but it is tracked anyway." > I agree, and I send a new patch. But I was not sure if I should add you in "Signed-off-by" list. Regards,
diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c index 00ee17c..d9efe32 100644 --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c @@ -81,7 +81,7 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff, } protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off); /* - * (protoff == skb->len) mean that the packet doesn't have no data + * (protoff == skb->len) mean that the packet does not have any data * except of IPv6 & ext headers. but it's tracked anyway. - YK */ if (protoff < 0 || (frag_off & htons(~0x7)) != 0) {
The double negation is probably a typo error Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr> --- net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)