Message ID | 1353140814-26164-1-git-send-email-maxime.ripard@free-electrons.com |
---|---|
State | Changes Requested |
Headers | show |
>>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:
Maxime> Fixes
Maxime> http://autobuild.buildroot.org/results/7ee57d01917ea72d1811469e482513dda2ceb1ea/build-end.log
Maxime> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime> ---
Maxime> package/libffi/Config.in | 1 +
Maxime> package/libglib2/Config.in | 1 +
Maxime> package/python/Config.in | 1 +
Maxime> package/python3/Config.in | 1 +
Maxime> 4 files changed, 4 insertions(+)
Maxime> diff --git a/package/libffi/Config.in b/package/libffi/Config.in
Maxime> index 7211f8f..6c7688c 100644
Maxime> --- a/package/libffi/Config.in
Maxime> +++ b/package/libffi/Config.in
Maxime> @@ -1,5 +1,6 @@
Maxime> config BR2_PACKAGE_LIBFFI
Maxime> bool "libffi"
Maxime> + depends on BR2_TOOLCHAIN_HAS_THREADS
Maxime> help
Maxime> The libffi library provides a portable, high level
Maxime> programming interface to various calling conventions. This
Maxime> diff --git a/package/libglib2/Config.in b/package/libglib2/Config.in
Maxime> index 5282885..7b1040c 100644
Maxime> --- a/package/libglib2/Config.in
Maxime> +++ b/package/libglib2/Config.in
Maxime> @@ -5,6 +5,7 @@ config BR2_PACKAGE_LIBGLIB2
Maxime> select BR2_PACKAGE_LIBFFI
Maxime> select BR2_PACKAGE_ZLIB
Maxime> depends on BR2_USE_WCHAR # gettext
Maxime> + depends on BR2_TOOLCHAIN_HAS_THREADS # libffi
You will unfortunately also have to add it everywhere a package selects
libglib2 (and the packages selecting those):
git grep -l 'select BR2_PACKAGE_LIBGLIB2' package
package/atk/Config.in
package/bluez_utils/Config.in
package/connman/Config.in
package/dbus-glib/Config.in
package/docker/Config.in
package/enchant/Config.in
package/gamin/Config.in
package/gdk-pixbuf/Config.in
package/glib-networking/Config.in
package/gmpc/Config.in
package/gob2/Config.in
package/gvfs/Config.in
package/latencytop/Config.in
package/libglade/Config.in
package/libgtk2/Config.in
package/libmms/Config.in
package/libmpd/Config.in
package/librsvg/Config.in
package/libsoup/Config.in
package/lttng-babeltrace/Config.in
package/multimedia/gstreamer/Config.in
package/multimedia/mpd/Config.in
package/nbd/Config.in
Dear Maxime Ripard, On Sat, 17 Nov 2012 09:26:54 +0100, Maxime Ripard wrote: > Fixes > http://autobuild.buildroot.org/results/7ee57d01917ea72d1811469e482513dda2ceb1ea/build-end.log > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> As Peter said, your patch cannot work, as we have to fix all the reverse dependencies. I'll try to cook a patch that removes the libffi dependency on threads when threads are not available. Best regards, Thomas
diff --git a/package/libffi/Config.in b/package/libffi/Config.in index 7211f8f..6c7688c 100644 --- a/package/libffi/Config.in +++ b/package/libffi/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBFFI bool "libffi" + depends on BR2_TOOLCHAIN_HAS_THREADS help The libffi library provides a portable, high level programming interface to various calling conventions. This diff --git a/package/libglib2/Config.in b/package/libglib2/Config.in index 5282885..7b1040c 100644 --- a/package/libglib2/Config.in +++ b/package/libglib2/Config.in @@ -5,6 +5,7 @@ config BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBFFI select BR2_PACKAGE_ZLIB depends on BR2_USE_WCHAR # gettext + depends on BR2_TOOLCHAIN_HAS_THREADS # libffi help Low-level core library that forms the basis of GTK+ and GNOME. diff --git a/package/python/Config.in b/package/python/Config.in index 4089cce..af80ec4 100644 --- a/package/python/Config.in +++ b/package/python/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON depends on BR2_USE_WCHAR # uses fork() depends on BR2_USE_MMU + depends on BR2_TOOLCHAIN_HAS_THREADS # libffi select BR2_PACKAGE_LIBFFI help The python language interpreter. diff --git a/package/python3/Config.in b/package/python3/Config.in index 2e1e98b..4f5e67d 100644 --- a/package/python3/Config.in +++ b/package/python3/Config.in @@ -1,6 +1,7 @@ config BR2_PACKAGE_PYTHON3 bool "python3" depends on BR2_USE_WCHAR + depends on BR2_TOOLCHAIN_HAS_THREADS # libffi select BR2_PACKAGE_LIBFFI help The python language interpreter.
Fixes http://autobuild.buildroot.org/results/7ee57d01917ea72d1811469e482513dda2ceb1ea/build-end.log Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- package/libffi/Config.in | 1 + package/libglib2/Config.in | 1 + package/python/Config.in | 1 + package/python3/Config.in | 1 + 4 files changed, 4 insertions(+)