Message ID | 509C686F.20400@gmail.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, 9 Nov 2012, Shan Wei wrote: > diff --git a/net/core/flow.c b/net/core/flow.c > index e318c7e..b0901ee 100644 > --- a/net/core/flow.c > +++ b/net/core/flow.c > @@ -327,11 +327,9 @@ static void flow_cache_flush_tasklet(unsigned long data) > static void flow_cache_flush_per_cpu(void *data) > { > struct flow_flush_info *info = data; > - int cpu; > struct tasklet_struct *tasklet; > > - cpu = smp_processor_id(); > - tasklet = &per_cpu_ptr(info->cache->percpu, cpu)->flush_tasklet; > + tasklet = this_cpu_ptr(&info->cache->percpu->flush_tasklet); > tasklet->data = (unsigned long)info; this_cpu_write(info->cache->percpu->flush_tasklet->data, (unsigned long)info); should also do the trick in less instructions and get rid of all temporary variables as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2012-11-09 at 20:08 +0000, Christoph Lameter wrote: > On Fri, 9 Nov 2012, Shan Wei wrote: > > > diff --git a/net/core/flow.c b/net/core/flow.c > > index e318c7e..b0901ee 100644 > > --- a/net/core/flow.c > > +++ b/net/core/flow.c > > @@ -327,11 +327,9 @@ static void flow_cache_flush_tasklet(unsigned long data) > > static void flow_cache_flush_per_cpu(void *data) > > { > > struct flow_flush_info *info = data; > > - int cpu; > > struct tasklet_struct *tasklet; > > > > - cpu = smp_processor_id(); > > - tasklet = &per_cpu_ptr(info->cache->percpu, cpu)->flush_tasklet; > > + tasklet = this_cpu_ptr(&info->cache->percpu->flush_tasklet); > > tasklet->data = (unsigned long)info; > > this_cpu_write(info->cache->percpu->flush_tasklet->data, (unsigned > long)info); > > should also do the trick in less instructions and get rid of all temporary > variables as well. Its not the case. We need the _pointer_ to call : tasklet_schedule(tasklet); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 9 Nov 2012, Eric Dumazet wrote: > Its not the case. > > We need the _pointer_ to call : > > tasklet_schedule(tasklet); Ah. Ok. In that case Reviewed-by: Christoph Lameter <cl@linux.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/flow.c b/net/core/flow.c index e318c7e..b0901ee 100644 --- a/net/core/flow.c +++ b/net/core/flow.c @@ -327,11 +327,9 @@ static void flow_cache_flush_tasklet(unsigned long data) static void flow_cache_flush_per_cpu(void *data) { struct flow_flush_info *info = data; - int cpu; struct tasklet_struct *tasklet; - cpu = smp_processor_id(); - tasklet = &per_cpu_ptr(info->cache->percpu, cpu)->flush_tasklet; + tasklet = this_cpu_ptr(&info->cache->percpu->flush_tasklet); tasklet->data = (unsigned long)info; tasklet_schedule(tasklet); }