diff mbox

fec: do not use memcpy on physical addresses

Message ID 1231949353-29630-5-git-send-email-s.hauer@pengutronix.de
State RFC, archived
Delegated to: David Miller
Headers show

Commit Message

Sascha Hauer Jan. 14, 2009, 4:09 p.m. UTC 
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/fec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Greg Ungerer Jan. 15, 2009, 3:55 a.m. UTC | #1 
Hi Sacha,

Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---

Also fine for ColdFire.

Acked-by: Greg Ungerer <gerg@uclinux.org>



>  drivers/net/fec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 1a07d56..29df0df 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -339,7 +339,7 @@ fec_enet_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  	if (bdp->cbd_bufaddr & 0x3) {
>  		unsigned int index;
>  		index = bdp - fep->tx_bd_base;
> -		memcpy(fep->tx_bounce[index], (void *) bdp->cbd_bufaddr, bdp->cbd_datlen);
> +		memcpy(fep->tx_bounce[index], (void *)skb->data, skb->len);
>  		bdp->cbd_bufaddr = __pa(fep->tx_bounce[index]);
>  	}
>
diff mbox

Patch

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 1a07d56..29df0df 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -339,7 +339,7 @@  fec_enet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	if (bdp->cbd_bufaddr & 0x3) {
 		unsigned int index;
 		index = bdp - fep->tx_bd_base;
-		memcpy(fep->tx_bounce[index], (void *) bdp->cbd_bufaddr, bdp->cbd_datlen);
+		memcpy(fep->tx_bounce[index], (void *)skb->data, skb->len);
 		bdp->cbd_bufaddr = __pa(fep->tx_bounce[index]);
 	}