diff mbox

[U-Boot,2/3] mx25: fix compilation when CONFIG_FSL_ESDHC is enabled

Message ID 1348347039-26521-2-git-send-email-eric@eukrea.com
State Changes Requested
Delegated to: Stefano Babic
Headers show

Commit Message

Eric Benard Sept. 22, 2012, 8:50 p.m. UTC 
else we get :
generic.c: In function 'get_clocks':
generic.c:210: error: 'MXC_ESDHC_CLK' undeclared (first use in this function)

please note this fix is a hack similar to the one used in
arch/arm/cpu/arm1136/mx35/generic.c
and will pevent the usage of eSDHC2 (as done on i/MX35).

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 arch/arm/cpu/arm926ejs/mx25/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Otavio Salvador Sept. 22, 2012, 9:14 p.m. UTC | #1 
On Sat, Sep 22, 2012 at 5:50 PM, Eric Bénard <eric@eukrea.com> wrote:
> else we get :
> generic.c: In function 'get_clocks':
> generic.c:210: error: 'MXC_ESDHC_CLK' undeclared (first use in this function)
>
> please note this fix is a hack similar to the one used in
> arch/arm/cpu/arm1136/mx35/generic.c
> and will pevent the usage of eSDHC2 (as done on i/MX35).
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>

What about working in the proper fix then?
Benoît Thébaudeau Sept. 22, 2012, 9:24 p.m. UTC | #2 
Hi Otavio, Eric,

On Saturday, September 22, 2012 11:14:40 PM, Otavio Salvador wrote:
> On Sat, Sep 22, 2012 at 5:50 PM, Eric Bénard <eric@eukrea.com> wrote:
> > else we get :
> > generic.c: In function 'get_clocks':
> > generic.c:210: error: 'MXC_ESDHC_CLK' undeclared (first use in this
> > function)
> >
> > please note this fix is a hack similar to the one used in
> > arch/arm/cpu/arm1136/mx35/generic.c
> > and will pevent the usage of eSDHC2 (as done on i/MX35).
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> 
> What about working in the proper fix then?

Note that I have such a fix. I have already posted it for i.MX35, but it's
missing a part that I will post soon, and I have the same fix for i.MX25 that I
will also post soon.

Best regards,
Benoît
diff mbox

Patch

diff --git a/arch/arm/cpu/arm926ejs/mx25/generic.c b/arch/arm/cpu/arm926ejs/mx25/generic.c
index cb74b82..6a3a8b3 100644
--- a/arch/arm/cpu/arm926ejs/mx25/generic.c
+++ b/arch/arm/cpu/arm926ejs/mx25/generic.c
@@ -207,7 +207,7 @@  int cpu_eth_init(bd_t *bis)
 int get_clocks(void)
 {
 #ifdef CONFIG_FSL_ESDHC
-	gd->sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
+	gd->sdhc_clk = mxc_get_clock(MXC_ESDHC1_CLK);
 #endif
 	return 0;
 }