[U-Boot] mxs: Convert timeout parameter to 'unsigned int'

Message ID	1345666211-25992-1-git-send-email-festevam@gmail.com
State	Accepted
Commit	a123312f4de2d6d29a04f454db9b760ccfe602ea
Delegated to:	Stefano Babic
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Fabio Estevam <festevam@gmail.com> To: sbabic@denx.de Date: Wed, 22 Aug 2012 17:10:11 -0300 Message-Id: <1345666211-25992-1-git-send-email-festevam@gmail.com> Cc: marex@denx.de, u-boot@lists.denx.de, Fabio Estevam <fabio.estevam@freescale.com> Subject: [U-Boot] [PATCH] mxs: Convert timeout parameter to 'unsigned int' Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de

Message ID

1345666211-25992-1-git-send-email-festevam@gmail.com

State

Accepted

Commit

a123312f4de2d6d29a04f454db9b760ccfe602ea

Delegated to:

Stefano Babic

Headers

show

Return-Path: <u-boot-bounces@lists.denx.de>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from theia.denx.de (theia.denx.de [85.214.87.163])
	by ozlabs.org (Postfix) with ESMTP id 25B6C2C009E
	for <incoming@patchwork.ozlabs.org>;
	Thu, 23 Aug 2012 06:10:47 +1000 (EST)
Received: from localhost (localhost [127.0.0.1])
	by theia.denx.de (Postfix) with ESMTP id D78E62807E;
	Wed, 22 Aug 2012 22:10:44 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at theia.denx.de
Received: from theia.denx.de ([127.0.0.1])
	by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id aVsiuypXyLJ5; Wed, 22 Aug 2012 22:10:44 +0200 (CEST)
Received: from theia.denx.de (localhost [127.0.0.1])
	by theia.denx.de (Postfix) with ESMTP id BD81628081;
	Wed, 22 Aug 2012 22:10:40 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by theia.denx.de (Postfix) with ESMTP id AE1AD28081
	for <u-boot@lists.denx.de>; Wed, 22 Aug 2012 22:10:37 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at theia.denx.de
Received: from theia.denx.de ([127.0.0.1])
	by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id jmXNNb-24vid for <u-boot@lists.denx.de>;
	Wed, 22 Aug 2012 22:10:36 +0200 (CEST)
X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5
	NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested)
Received: from mail-gg0-f172.google.com (mail-gg0-f172.google.com
	[209.85.161.172])
	by theia.denx.de (Postfix) with ESMTPS id 9D89A2807E
	for <u-boot@lists.denx.de>; Wed, 22 Aug 2012 22:10:34 +0200 (CEST)
Received: by ggnh4 with SMTP id h4so1045246ggn.3
	for <u-boot@lists.denx.de>; Wed, 22 Aug 2012 13:10:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=from:to:cc:subject:date:message-id:x-mailer;
	bh=zi+dxe1Od9IH9xNKUpa2PpMBf42BFx1aVvs7dxKpYXc=;
	b=G6mkmPL47JE/m9H5XjQfgWyJHQDzHZzxXKC7W5aj3ZVqY64AEk0e+co4FdK4aT7JXc
	zswkTa9ZLbplRfmw8bhuF4LEtqh1A+FRlAZFKmrMi6IvVHvFZmujGwh49sQW5cVelFBK
	ogRyGvcJYy9G9PWJ7ud8pHB5GbLL9rE0KotdxVT3qhHd0BIbsSKnDsB2O19+MdbZ18G4
	Jr2Qc0OiPI06umK/5Y3Asmfa5bYoWnXkvjvLDqKWmEOBc1ouzFhUzTYQVfGYH+So97Ga
	BeBopXyarzPZwugs59pvOEowMHs4vh6D0dUUlPXlSYzeHpxpzWpjoToesMvIg45/cklR
	FT4w==
Received: by 10.236.75.132 with SMTP id z4mr29460680yhd.25.1345666231461;
	Wed, 22 Aug 2012 13:10:31 -0700 (PDT)
Received: from fabio-Latitude-E6410.cps.virtua.com.br ([201.82.136.222])
	by mx.google.com with ESMTPS id h8sm4907550ank.9.2012.08.22.13.10.28
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 22 Aug 2012 13:10:30 -0700 (PDT)
From: Fabio Estevam <festevam@gmail.com>
To: sbabic@denx.de
Date: Wed, 22 Aug 2012 17:10:11 -0300
Message-Id: <1345666211-25992-1-git-send-email-festevam@gmail.com>
X-Mailer: git-send-email 1.7.9.5
Cc: marex@denx.de, u-boot@lists.denx.de,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: [U-Boot] [PATCH] mxs: Convert timeout parameter to 'unsigned int'
X-BeenThere: u-boot@lists.denx.de
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: U-Boot discussion <u-boot.lists.denx.de>
List-Unsubscribe: <http://lists.denx.de/mailman/options/u-boot>,
	<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>
List-Archive: <http://lists.denx.de/pipermail/u-boot>
List-Post: <mailto:u-boot@lists.denx.de>
List-Help: <mailto:u-boot-request@lists.denx.de?subject=help>
List-Subscribe: <http://lists.denx.de/mailman/listinfo/u-boot>,
	<mailto:u-boot-request@lists.denx.de?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: u-boot-bounces@lists.denx.de
Errors-To: u-boot-bounces@lists.denx.de

Commit Message

Fabio Estevam Aug. 22, 2012, 8:10 p.m. UTC

From: Fabio Estevam <fabio.estevam@freescale.com>>

For representing a timeout value, it makes more sense to pass it as
'unsigned int'.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/cpu/arm926ejs/mxs/mxs.c          |    6 ++++--
 arch/arm/include/asm/arch-mxs/sys_proto.h |    4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Marek Vasut Aug. 22, 2012, 8:16 p.m. UTC | #1

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>>
> 
> For representing a timeout value, it makes more sense to pass it as
> 'unsigned int'.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  arch/arm/cpu/arm926ejs/mxs/mxs.c          |    6 ++++--
>  arch/arm/include/asm/arch-mxs/sys_proto.h |    4 ++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> b/arch/arm/cpu/arm926ejs/mxs/mxs.c index c028e5e..19c79f2 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> @@ -81,7 +81,8 @@ void enable_caches(void)
>  #endif
>  }
> 
> -int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int
> timeout) +int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t
> mask, unsigned +								
int timeout)
>  {
>  	while (--timeout) {
>  		if ((readl(&reg->reg) & mask) == mask)
> @@ -92,7 +93,8 @@ int mxs_wait_mask_set(struct mxs_register_32 *reg,
> uint32_t mask, int timeout) return !timeout;
>  }
> 
> -int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, int
> timeout) +int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t
> mask, unsigned +								
int timeout)
>  {
>  	while (--timeout) {
>  		if ((readl(&reg->reg) & mask) == 0)
> diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h
> b/arch/arm/include/asm/arch-mxs/sys_proto.h index 4610363..983b888 100644
> --- a/arch/arm/include/asm/arch-mxs/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
> @@ -26,10 +26,10 @@
>  int mxs_reset_block(struct mxs_register_32 *reg);
>  int mxs_wait_mask_set(struct mxs_register_32 *reg,
>  		       uint32_t mask,
> -		       int timeout);
> +		       unsigned int timeout);
>  int mxs_wait_mask_clr(struct mxs_register_32 *reg,
>  		       uint32_t mask,
> -		       int timeout);
> +		       unsigned int timeout);
> 
>  int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int));

Best regards,
Marek Vasut

Stefano Babic Aug. 23, 2012, 10:17 a.m. UTC | #2

On 22/08/2012 22:10, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>>
> 
> For representing a timeout value, it makes more sense to pass it as
> 'unsigned int'.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/cpu/arm926ejs/mxs/mxs.c          |    6 ++++--
>  arch/arm/include/asm/arch-mxs/sys_proto.h |    4 ++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> index c028e5e..19c79f2 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> @@ -81,7 +81,8 @@ void enable_caches(void)
>  #endif
>  }
>  
> -int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)
> +int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, unsigned
> +								int timeout)
>  {
>  	while (--timeout) {
>  		if ((readl(&reg->reg) & mask) == mask)
> @@ -92,7 +93,8 @@ int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)
>  	return !timeout;
>  }
>  
> -int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, int timeout)
> +int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, unsigned
> +								int timeout)
>  {
>  	while (--timeout) {
>  		if ((readl(&reg->reg) & mask) == 0)
> diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h
> index 4610363..983b888 100644
> --- a/arch/arm/include/asm/arch-mxs/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
> @@ -26,10 +26,10 @@
>  int mxs_reset_block(struct mxs_register_32 *reg);
>  int mxs_wait_mask_set(struct mxs_register_32 *reg,
>  		       uint32_t mask,
> -		       int timeout);
> +		       unsigned int timeout);
>  int mxs_wait_mask_clr(struct mxs_register_32 *reg,
>  		       uint32_t mask,
> -		       int timeout);
> +		       unsigned int timeout);
>  
>  int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int));
>  
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

Stefano Babic Aug. 27, 2012, 6:28 a.m. UTC | #3

On 22/08/2012 22:10, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>>
> 
> For representing a timeout value, it makes more sense to pass it as
> 'unsigned int'.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/cpu/arm926ejs/mxs/mxs.c          |    6 ++++--
>  arch/arm/include/asm/arch-mxs/sys_proto.h |    4 ++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> index c028e5e..19c79f2 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> @@ -81,7 +81,8 @@ void enable_caches(void)
>  #endif
>  }
>  
> -int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)
> +int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, unsigned
> +								int timeout)
>  {
>  	while (--timeout) {
>  		if ((readl(&reg->reg) & mask) == mask)
> @@ -92,7 +93,8 @@ int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)
>  	return !timeout;
>  }
>  
> -int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, int timeout)
> +int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, unsigned
> +								int timeout)
>  {
>  	while (--timeout) {
>  		if ((readl(&reg->reg) & mask) == 0)
> diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h
> index 4610363..983b888 100644
> --- a/arch/arm/include/asm/arch-mxs/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
> @@ -26,10 +26,10 @@
>  int mxs_reset_block(struct mxs_register_32 *reg);
>  int mxs_wait_mask_set(struct mxs_register_32 *reg,
>  		       uint32_t mask,
> -		       int timeout);
> +		       unsigned int timeout);
>  int mxs_wait_mask_clr(struct mxs_register_32 *reg,
>  		       uint32_t mask,
> -		       int timeout);
> +		       unsigned int timeout);
>  
>  int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int));
>  
> 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
index c028e5e..19c79f2 100644
--- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
+++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
@@ -81,7 +81,8 @@  void enable_caches(void)
 #endif
 }
 
-int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)
+int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, unsigned
+								int timeout)
 {
 	while (--timeout) {
 		if ((readl(&reg->reg) & mask) == mask)
@@ -92,7 +93,8 @@  int mxs_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)
 	return !timeout;
 }
 
-int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, int timeout)
+int mxs_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, unsigned
+								int timeout)
 {
 	while (--timeout) {
 		if ((readl(&reg->reg) & mask) == 0)
diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h
index 4610363..983b888 100644
--- a/arch/arm/include/asm/arch-mxs/sys_proto.h
+++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
@@ -26,10 +26,10 @@ 
 int mxs_reset_block(struct mxs_register_32 *reg);
 int mxs_wait_mask_set(struct mxs_register_32 *reg,
 		       uint32_t mask,
-		       int timeout);
+		       unsigned int timeout);
 int mxs_wait_mask_clr(struct mxs_register_32 *reg,
 		       uint32_t mask,
-		       int timeout);
+		       unsigned int timeout);
 
 int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int));

[U-Boot] mxs: Convert timeout parameter to 'unsigned int'

Commit Message

Comments

Patch