diff mbox

[U-Boot,1/2] mx28evk: Remove unneeded 'undef'

Message ID 1345332492-3273-1-git-send-email-festevam@gmail.com
State Accepted
Commit 685659c54324c691a2b1f6e020c141bf3672efe1
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Aug. 18, 2012, 11:28 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to undef an option that is not enabled by default.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx28evk.h |    1 -
 1 file changed, 1 deletion(-)

Comments

Marek Vasut Aug. 18, 2012, 11:43 p.m. UTC | #1 
Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to undef an option that is not enabled by default.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx28evk.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
>  #define CONFIG_SF_DEFAULT_SPEED		24000000
> 
>  /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
>  #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
>  #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
>  #define CONFIG_ENV_SIZE			0x1000		/* 4KB */

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut
Stefano Babic Aug. 19, 2012, 8:41 a.m. UTC | #2 
On 19/08/2012 01:28, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to undef an option that is not enabled by default.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx28evk.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
>  #define CONFIG_SF_DEFAULT_SPEED		24000000
>  
>  /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
>  #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
>  #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
>  #define CONFIG_ENV_SIZE			0x1000		/* 4KB */
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Regards,
Stefano
Stefano Babic Aug. 20, 2012, 8:02 a.m. UTC | #3 
On 19/08/2012 01:28, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to undef an option that is not enabled by default.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx28evk.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
>  #define CONFIG_SF_DEFAULT_SPEED		24000000
>  
>  /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
>  #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
>  #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
>  #define CONFIG_ENV_SIZE			0x1000		/* 4KB */
> 

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 4e70617..b677e51 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -215,7 +215,6 @@ 
 #define CONFIG_SF_DEFAULT_SPEED		24000000
 
 /* (redundant) environemnt in SPI flash */
-#undef CONFIG_ENV_IS_IN_SPI_FLASH
 #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
 #define CONFIG_ENV_SIZE			0x1000		/* 4KB */