Message ID | 1341398037-7591-1-git-send-email-jacmet@sunsite.dk |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Peter Korsgaard <jacmet@sunsite.dk> Date: Wed, 4 Jul 2012 12:33:57 +0200 > The bcm87xx phys don't support autonegotiation, so don't use it by > default, as otherwise phy_state_machine() will try to enable it (using > c22 requests, which also don't make any sense for the bcm78xx). > > Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk> Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c index f5f0562..9a90dcf 100644 --- a/drivers/net/phy/bcm87xx.c +++ b/drivers/net/phy/bcm87xx.c @@ -89,6 +89,7 @@ static int bcm87xx_config_init(struct phy_device *phydev) phydev->supported = SUPPORTED_10000baseR_FEC; phydev->advertising = ADVERTISED_10000baseR_FEC; phydev->state = PHY_NOLINK; + phydev->autoneg = AUTONEG_DISABLE; bcm87xx_of_reg_init(phydev);
The bcm87xx phys don't support autonegotiation, so don't use it by default, as otherwise phy_state_machine() will try to enable it (using c22 requests, which also don't make any sense for the bcm78xx). Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk> --- Tested on a bcm8707, which uses the same id as 8727 drivers/net/phy/bcm87xx.c | 1 + 1 file changed, 1 insertion(+)