diff mbox

xf86-input-vmmouse: Make xf86-input-vmmouse available only to x86/x86_64 architectures

Message ID 1335368289-19192-1-git-send-email-markos.chandras@imgtec.com
State Superseded, archived
Headers show

Commit Message

Markos Chandras April 25, 2012, 3:38 p.m. UTC
The xf86-input-vmmouse source code fails to compile intentionally on any
architecture but x86/x86_64. The following error is printed when compiling for a
different architecture:

vmmouse_proto.h:62:2: error: #error The vmmouse protocol is only supported on
x86 architectures.
vmmouse_proto.c:117:2: error: #error "VMMouse is only supported on x86 and
x86-64.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 package/x11r7/xdriver_xf86-input-vmmouse/Config.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni April 25, 2012, 3:42 p.m. UTC | #1
Le Wed, 25 Apr 2012 16:38:09 +0100,
Markos Chandras <markos.chandras@imgtec.com> a écrit :

> diff --git a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> index 377e7e4..dc24691 100644
> --- a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> +++ b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> @@ -1,3 +1,4 @@
> +if BR2_i386 || BR2_x86_64

I would prefer a

	depends on BR2_i386 || BR2_x86_64

below:

config BR2_PACKAGE_XDRIVER_XF86_INPUT_VMMOUSE
  	bool "xf86-input-vmmouse"

because that's what we do for all other packages.

Thomas
Markos Chandras April 25, 2012, 3:47 p.m. UTC | #2
On 04/25/2012 04:42 PM, Thomas Petazzoni wrote:

> Le Wed, 25 Apr 2012 16:38:09 +0100,
> Markos Chandras <markos.chandras@imgtec.com> a écrit :
> 
>> diff --git a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
> b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
>> index 377e7e4..dc24691 100644
>> --- a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
>> +++ b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
>> @@ -1,3 +1,4 @@
>> +if BR2_i386 || BR2_x86_64
> 
> I would prefer a
> 
>         depends on BR2_i386 || BR2_x86_64
> 
> below:
> 
> config BR2_PACKAGE_XDRIVER_XF86_INPUT_VMMOUSE
>         bool "xf86-input-vmmouse"
> 
> because that's what we do for all other packages.
> 
> Thomas


Hi Thomas,

Thanks. A new patch is coming asap
diff mbox

Patch

diff --git a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
index 377e7e4..dc24691 100644
--- a/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
+++ b/package/x11r7/xdriver_xf86-input-vmmouse/Config.in
@@ -1,3 +1,4 @@ 
+if BR2_i386 || BR2_x86_64
 config BR2_PACKAGE_XDRIVER_XF86_INPUT_VMMOUSE
 	bool "xf86-input-vmmouse"
 	select BR2_PACKAGE_XSERVER_XORG_SERVER
@@ -6,3 +7,4 @@  config BR2_PACKAGE_XDRIVER_XF86_INPUT_VMMOUSE
 	select BR2_PACKAGE_XPROTO_XPROTO
 	help
 	  VMWare mouse input driver
+endif