| Message ID | 1334689297-13489-11-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Tue, Apr 17, 2012 at 12:01:37PM -0700, Simon Glass wrote: > This enables the standard keyboard on Seaboard. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > include/configs/seaboard.h | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h > index 3306622..1ee7e12 100644 > --- a/include/configs/seaboard.h > +++ b/include/configs/seaboard.h > @@ -114,4 +114,13 @@ > > /* Somewhat oddly, the NAND base address must be a config option */ > #define CONFIG_SYS_NAND_BASE TEGRA2_NAND_BASE > + > +/* Enable keyboard */ > +#define CONFIG_TEGRA2_KEYBOARD > +#define CONFIG_KEYBOARD > + > +#undef TEGRA2_DEVICE_SETTINGS > +#define TEGRA2_DEVICE_SETTINGS "stdin=serial,tegra-kbc\0" \ "usbkbd" would be nice for the springbank version of seaboard, although that requires CONFIG_USB_KEYBOARD and CONFIG_SYS_USB_EVENT_POLL as well, so maybe I should just post a separate patch. -Allen
Hi Allen, On Fri, Apr 20, 2012 at 4:57 PM, Allen Martin <amartin@nvidia.com> wrote: > On Tue, Apr 17, 2012 at 12:01:37PM -0700, Simon Glass wrote: >> This enables the standard keyboard on Seaboard. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> include/configs/seaboard.h | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h >> index 3306622..1ee7e12 100644 >> --- a/include/configs/seaboard.h >> +++ b/include/configs/seaboard.h >> @@ -114,4 +114,13 @@ >> >> /* Somewhat oddly, the NAND base address must be a config option */ >> #define CONFIG_SYS_NAND_BASE TEGRA2_NAND_BASE >> + >> +/* Enable keyboard */ >> +#define CONFIG_TEGRA2_KEYBOARD >> +#define CONFIG_KEYBOARD >> + >> +#undef TEGRA2_DEVICE_SETTINGS >> +#define TEGRA2_DEVICE_SETTINGS "stdin=serial,tegra-kbc\0" \ > > "usbkbd" would be nice for the springbank version of seaboard, > although that requires CONFIG_USB_KEYBOARD and > CONFIG_SYS_USB_EVENT_POLL as well, so maybe I should just post a > separate patch. Sounds good. Regards, Simon > > -Allen > -- > nvpublic
On 04/17/2012 01:01 PM, Simon Glass wrote: > This enables the standard keyboard on Seaboard. Hmmm. I wonder what this patch will do to the Springbank variant of Seaboard, which actually contains a USB keyboard rather than a Tegra KBC keyboard? It looks like the relevant pins on Tegra are simply not connected, so coupled with the pull-up in the KBC's funcmux setting, this should work out OK; the keyboard will just appear idle. So, Acked-by: Stephen Warren <swarren@wwwdotorg.org>
diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h index 3306622..1ee7e12 100644 --- a/include/configs/seaboard.h +++ b/include/configs/seaboard.h @@ -114,4 +114,13 @@ /* Somewhat oddly, the NAND base address must be a config option */ #define CONFIG_SYS_NAND_BASE TEGRA2_NAND_BASE + +/* Enable keyboard */ +#define CONFIG_TEGRA2_KEYBOARD +#define CONFIG_KEYBOARD + +#undef TEGRA2_DEVICE_SETTINGS +#define TEGRA2_DEVICE_SETTINGS "stdin=serial,tegra-kbc\0" \ + "stdout=serial\0" \ + "stderr=serial\0" #endif /* __CONFIG_H */
This enables the standard keyboard on Seaboard. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/configs/seaboard.h | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)