diff mbox

net: fix compile error of leaking kmemleak.h header

Message ID 4F8F8F1A.6020000@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

solomon April 19, 2012, 4:05 a.m. UTC
From: Shan Wei <davidshan@tencent.com>

net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’

with same error in net/ipv4/route.c

Signed-off-by: Shan Wei <davidshan@tencent.com>
---
 net/core/sysctl_net_core.c |    1 +
 net/ipv4/route.c           |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

Comments

solomon April 19, 2012, 4:08 a.m. UTC | #1
Shan Wei said, at 2012/4/19 12:05:

> From: Shan Wei <davidshan@tencent.com>
> 
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
> 
> with same error in net/ipv4/route.c


This is for net-next.....
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller April 19, 2012, 4:13 a.m. UTC | #2
From: Shan Wei <shanwei88@gmail.com>

Date: Thu, 19 Apr 2012 12:05:46 +0800

> From: Shan Wei <davidshan@tencent.com>

> 

> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:

> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’

> 

> with same error in net/ipv4/route.c

> 

> Signed-off-by: Shan Wei <davidshan@tencent.com>


Applied, thanks.
Eric Dumazet April 19, 2012, 4:22 a.m. UTC | #3
On Thu, 2012-04-19 at 12:05 +0800, Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
> 
> net/core/sysctl_net_core.c: In function ‘sysctl_core_init’:
> net/core/sysctl_net_core.c:259: error: implicit declaration of function ‘kmemleak_not_leak’
> 
> with same error in net/ipv4/route.c
> 
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> ---
>  net/core/sysctl_net_core.c |    1 +
>  net/ipv4/route.c           |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index cee5991..247c69b 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -14,6 +14,7 @@
>  #include <linux/vmalloc.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> +#include <linux/kmemleak.h>
>  
>  #include <net/ip.h>
>  #include <net/sock.h>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index bcd4744..a1c115d 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -109,6 +109,7 @@
>  #include <net/rtnetlink.h>
>  #ifdef CONFIG_SYSCTL
>  #include <linux/sysctl.h>
> +#include <linux/kmemleak.h>
>  #endif
>  #include <net/secure_seq.h>
>  

yep, SLAB doesnt include it like SLUB

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
index cee5991..247c69b 100644
--- a/net/core/sysctl_net_core.c
+++ b/net/core/sysctl_net_core.c
@@ -14,6 +14,7 @@ 
 #include <linux/vmalloc.h>
 #include <linux/init.h>
 #include <linux/slab.h>
+#include <linux/kmemleak.h>
 
 #include <net/ip.h>
 #include <net/sock.h>
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index bcd4744..a1c115d 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -109,6 +109,7 @@ 
 #include <net/rtnetlink.h>
 #ifdef CONFIG_SYSCTL
 #include <linux/sysctl.h>
+#include <linux/kmemleak.h>
 #endif
 #include <net/secure_seq.h>