| Message ID | alpine.LNX.2.00.1204092210470.13925@swampdragon.chaosbits.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
>From: Jesper Juhl [mailto:jj@chaosbits.net] >Sent: Monday, April 09, 2012 1:50 PM >To: linux-kernel@vger.kernel.org > >release_firmware() does its own NULL test so explicit test before call >is unneeded. > >Signed-off-by: Jesper Juhl <jj@chaosbits.net> Thanks Jesper! Acked-by: Rasesh Mody <rmody@brocade.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index ff78f77..d86390c 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -3546,9 +3546,7 @@ static void __exit bnad_module_exit(void) { pci_unregister_driver(&bnad_pci_driver); - - if (bfi_fw) - release_firmware(bfi_fw); + release_firmware(bfi_fw); } module_init(bnad_module_init);
release_firmware() does its own NULL test so explicit test before call is unneeded. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- drivers/net/ethernet/brocade/bna/bnad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)