diff mbox

[net] bnx2x: fix vector traveling while looking for an empty entry

Message ID 1332832135-22054-1-git-send-email-dmitry@broadcom.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Dmitry Kravkov March 27, 2012, 7:08 a.m. UTC
Fixes the bug that may prevent from mac to be configured,
while there is an empty slot for it.

Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Maciej Żenczykowski March 27, 2012, 6:06 p.m. UTC | #1
Ack.

On Tue, Mar 27, 2012 at 00:08, Dmitry Kravkov <dmitry@broadcom.com> wrote:
> Fixes the bug that may prevent from mac to be configured,
> while there is an empty slot for it.
>
> Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index 3f52fad..5135733 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -3847,7 +3847,7 @@ static bool bnx2x_credit_pool_get_entry(
>                        continue;
>
>                /* If we've got here we are going to find a free entry */
> -               for (idx = vec * BNX2X_POOL_VEC_SIZE, i = 0;
> +               for (idx = vec * BIT_VEC64_ELEM_SZ, i = 0;
>                      i < BIT_VEC64_ELEM_SZ; idx++, i++)
>
>                        if (BIT_VEC64_TEST_BIT(o->pool_mirror, idx)) {
> --
> 1.7.7.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller March 28, 2012, 2:41 a.m. UTC | #2
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Tue, 27 Mar 2012 09:08:55 +0200

> Fixes the bug that may prevent from mac to be configured,
> while there is an empty slot for it.
> 
> Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 3f52fad..5135733 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -3847,7 +3847,7 @@  static bool bnx2x_credit_pool_get_entry(
 			continue;
 
 		/* If we've got here we are going to find a free entry */
-		for (idx = vec * BNX2X_POOL_VEC_SIZE, i = 0;
+		for (idx = vec * BIT_VEC64_ELEM_SZ, i = 0;
 		      i < BIT_VEC64_ELEM_SZ; idx++, i++)
 
 			if (BIT_VEC64_TEST_BIT(o->pool_mirror, idx)) {