diff mbox

e1000: Silence sparse warnings by correcting type

Message ID 1332233951-31129-1-git-send-email-Andrei.Emeltchenko.news@gmail.com
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show

Commit Message

Andrei Emeltchenko March 20, 2012, 8:59 a.m. UTC
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Silence sparse warnings shown below:
...
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
	cast to restricted __le64
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
	cast to restricted __le64
...

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 drivers/net/ethernet/intel/e1000/e1000_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Andrei Emeltchenko March 23, 2012, 2:01 p.m. UTC | #1
ping

On Tue, Mar 20, 2012 at 10:59 AM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Silence sparse warnings shown below:
> ...
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
>        cast to restricted __le64
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
>        cast to restricted __le64
> ...
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 6419a88..1bf73cf 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
>        for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
>                struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
>                struct e1000_buffer *buffer_info = &tx_ring->buffer_info[i];
> -               struct my_u { u64 a; u64 b; };
> +               struct my_u { __le64 a; __le64 b; };
>                struct my_u *u = (struct my_u *)tx_desc;
>                const char *type;
>
> @@ -3421,7 +3421,7 @@ rx_ring_summary:
>        for (i = 0; rx_ring->desc && (i < rx_ring->count); i++) {
>                struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
>                struct e1000_buffer *buffer_info = &rx_ring->buffer_info[i];
> -               struct my_u { u64 a; u64 b; };
> +               struct my_u { __le64 a; __le64 b; };
>                struct my_u *u = (struct my_u *)rx_desc;
>                const char *type;
>
> --
> 1.7.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Kirsher March 25, 2012, 9:45 a.m. UTC | #2
On 03/20/2012 01:59 AM, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko<andrei.emeltchenko@intel.com>
>
> Silence sparse warnings shown below:
> ...
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> 	cast to restricted __le64
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> 	cast to restricted __le64
> ...
>
> Signed-off-by: Andrei Emeltchenko<andrei.emeltchenko@intel.com>
> ---
>   drivers/net/ethernet/intel/e1000/e1000_main.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 6419a88..1bf73cf 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
>   	for (i = 0; tx_ring->desc&&  (i<  tx_ring->count); i++) {
>   		struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
>   		struct e1000_buffer *buffer_info =&tx_ring->buffer_info[i];
> -		struct my_u { u64 a; u64 b; };
> +		struct my_u { __le64 a; __le64 b; };
>   		struct my_u *u = (struct my_u *)tx_desc;
>   		const char *type;
>
> @@ -3421,7 +3421,7 @@ rx_ring_summary:
>   	for (i = 0; rx_ring->desc&&  (i<  rx_ring->count); i++) {
>   		struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
>   		struct e1000_buffer *buffer_info =&rx_ring->buffer_info[i];
> -		struct my_u { u64 a; u64 b; };
> +		struct my_u { __le64 a; __le64 b; };
>   		struct my_u *u = (struct my_u *)rx_desc;
>   		const char *type;
>
Helps if you CC the maintainers (i.e. me)

Thanks, I will add it to my queue of e1000 patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 6419a88..1bf73cf 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -3377,7 +3377,7 @@  static void e1000_dump(struct e1000_adapter *adapter)
 	for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
 		struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
 		struct e1000_buffer *buffer_info = &tx_ring->buffer_info[i];
-		struct my_u { u64 a; u64 b; };
+		struct my_u { __le64 a; __le64 b; };
 		struct my_u *u = (struct my_u *)tx_desc;
 		const char *type;
 
@@ -3421,7 +3421,7 @@  rx_ring_summary:
 	for (i = 0; rx_ring->desc && (i < rx_ring->count); i++) {
 		struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
 		struct e1000_buffer *buffer_info = &rx_ring->buffer_info[i];
-		struct my_u { u64 a; u64 b; };
+		struct my_u { __le64 a; __le64 b; };
 		struct my_u *u = (struct my_u *)rx_desc;
 		const char *type;