| Message ID | 20241105182308.1216274-1-ju.o@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/libspdm: fix build due to missing macro definition | expand |
On Wed, Nov 6, 2024 at 4:23 AM Julien Olivain <ju.o@free.fr> wrote: > > Commit 967ba5386 "package/libspdm: bump version to 3.5.0" [1] > incorrectly removed the "0" to the LIBSPDM_ENABLE_CAPABILITY_MEL_CAP > macro definition. > > This results to libspdm build failure with errors like: > > In file included from /build/libspdm-3.5.0/include/internal/libspdm_common_lib.h:20, > from /build/libspdm-3.5.0/library/spdm_common_lib/libspdm_com_context_data.c:7: > /build/libspdm-3.5.0/include/hal/library/responder/measlib.h:154:38: error: #if with no expression > 154 | #if LIBSPDM_ENABLE_CAPABILITY_MEL_CAP > | ^ > > This commit fixes the issue by adding back this missing "0". > > Fixes: > https://autobuild.buildroot.org/results/88cb77a2e6b46028f9fb7f0325348a1b1b8fd931 > > [1] https://gitlab.com/buildroot.org/buildroot/-/commit/967ba5386d4e15102db88a9faae1845b3e69dc6f > > Signed-off-by: Julien Olivain <ju.o@free.fr> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > Patch tested (compilation only) in: > https://gitlab.com/jolivain/buildroot/-/pipelines/1528523473 > --- > package/libspdm/libspdm.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/libspdm/libspdm.mk b/package/libspdm/libspdm.mk > index 081bffb9c1..03ac9a70f8 100644 > --- a/package/libspdm/libspdm.mk > +++ b/package/libspdm/libspdm.mk > @@ -20,7 +20,7 @@ LIBSPDM_TARGET_CPU_FAMILY = $(call qstrip,$(BR2_PACKAGE_LIBSPDM_CPU_FAMILY)) > LIBSPDM_CFLAGS = \ > $(TARGET_CFLAGS) \ > -DLIBSPDM_ENABLE_CAPABILITY_EVENT_CAP=0 \ > - -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP= \ > + -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP=0 \ > -DLIBSPDM_ENABLE_CAPABILITY_GET_KEY_PAIR_INFO_CAP=0 \ > -DLIBSPDM_ENABLE_CAPABILITY_SET_KEY_PAIR_INFO_CAP=0 > > -- > 2.47.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
On Tue, 2024-11-05 at 19:23 +0100, Julien Olivain wrote: > Commit 967ba5386 "package/libspdm: bump version to 3.5.0" [1] > incorrectly removed the "0" to the LIBSPDM_ENABLE_CAPABILITY_MEL_CAP > macro definition. > > This results to libspdm build failure with errors like: > > In file included from /build/libspdm- > 3.5.0/include/internal/libspdm_common_lib.h:20, > from /build/libspdm- > 3.5.0/library/spdm_common_lib/libspdm_com_context_data.c:7: > /build/libspdm- > 3.5.0/include/hal/library/responder/measlib.h:154:38: error: #if with > no expression > 154 | #if LIBSPDM_ENABLE_CAPABILITY_MEL_CAP > | ^ > > This commit fixes the issue by adding back this missing "0". > > Fixes: > https://autobuild.buildroot.org/results/88cb77a2e6b46028f9fb7f0325348a1b1b8fd931 > > [1] > https://gitlab.com/buildroot.org/buildroot/-/commit/967ba5386d4e15102db88a9faae1845b3e69dc6f > > Signed-off-by: Julien Olivain <ju.o@free.fr> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com> Thanks! Wilfred > --- > Patch tested (compilation only) in: > https://gitlab.com/jolivain/buildroot/-/pipelines/1528523473 > --- > package/libspdm/libspdm.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/libspdm/libspdm.mk b/package/libspdm/libspdm.mk > index 081bffb9c1..03ac9a70f8 100644 > --- a/package/libspdm/libspdm.mk > +++ b/package/libspdm/libspdm.mk > @@ -20,7 +20,7 @@ LIBSPDM_TARGET_CPU_FAMILY = $(call > qstrip,$(BR2_PACKAGE_LIBSPDM_CPU_FAMILY)) > LIBSPDM_CFLAGS = \ > $(TARGET_CFLAGS) \ > -DLIBSPDM_ENABLE_CAPABILITY_EVENT_CAP=0 \ > - -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP= \ > + -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP=0 \ > -DLIBSPDM_ENABLE_CAPABILITY_GET_KEY_PAIR_INFO_CAP=0 \ > -DLIBSPDM_ENABLE_CAPABILITY_SET_KEY_PAIR_INFO_CAP=0 >
diff --git a/package/libspdm/libspdm.mk b/package/libspdm/libspdm.mk index 081bffb9c1..03ac9a70f8 100644 --- a/package/libspdm/libspdm.mk +++ b/package/libspdm/libspdm.mk @@ -20,7 +20,7 @@ LIBSPDM_TARGET_CPU_FAMILY = $(call qstrip,$(BR2_PACKAGE_LIBSPDM_CPU_FAMILY)) LIBSPDM_CFLAGS = \ $(TARGET_CFLAGS) \ -DLIBSPDM_ENABLE_CAPABILITY_EVENT_CAP=0 \ - -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP= \ + -DLIBSPDM_ENABLE_CAPABILITY_MEL_CAP=0 \ -DLIBSPDM_ENABLE_CAPABILITY_GET_KEY_PAIR_INFO_CAP=0 \ -DLIBSPDM_ENABLE_CAPABILITY_SET_KEY_PAIR_INFO_CAP=0
Commit 967ba5386 "package/libspdm: bump version to 3.5.0" [1] incorrectly removed the "0" to the LIBSPDM_ENABLE_CAPABILITY_MEL_CAP macro definition. This results to libspdm build failure with errors like: In file included from /build/libspdm-3.5.0/include/internal/libspdm_common_lib.h:20, from /build/libspdm-3.5.0/library/spdm_common_lib/libspdm_com_context_data.c:7: /build/libspdm-3.5.0/include/hal/library/responder/measlib.h:154:38: error: #if with no expression 154 | #if LIBSPDM_ENABLE_CAPABILITY_MEL_CAP | ^ This commit fixes the issue by adding back this missing "0". Fixes: https://autobuild.buildroot.org/results/88cb77a2e6b46028f9fb7f0325348a1b1b8fd931 [1] https://gitlab.com/buildroot.org/buildroot/-/commit/967ba5386d4e15102db88a9faae1845b3e69dc6f Signed-off-by: Julien Olivain <ju.o@free.fr> --- Patch tested (compilation only) in: https://gitlab.com/jolivain/buildroot/-/pipelines/1528523473 --- package/libspdm/libspdm.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)