| Message ID | 20241101135406.47836-1-festevam@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v4,1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, 01 Nov 2024 10:54:04 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long > > To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible > 'fsl,imx6sx-lcdif' fallback. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v3: > - Also update the example. > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On 01.11.24 14:54, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long > > To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible > 'fsl,imx6sx-lcdif' fallback. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > --- > Changes since v3: > - Also update the example. > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 8e3a98aeec32..aa3204b6aff9 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -19,7 +19,6 @@ properties: > - enum: > - fsl,imx23-lcdif > - fsl,imx28-lcdif > - - fsl,imx6sx-lcdif > - fsl,imx8mp-lcdif > - fsl,imx93-lcdif > - items: > @@ -32,6 +31,10 @@ properties: > - fsl,imx8mn-lcdif > - fsl,imx8mq-lcdif > - const: fsl,imx6sx-lcdif > + - items: > + - enum: > + - fsl,imx6sx-lcdif > + - const: fsl,imx28-lcdif > > reg: > maxItems: 1 > @@ -182,7 +185,7 @@ examples: > #include <dt-bindings/interrupt-controller/arm-gic.h> > > display-controller@2220000 { > - compatible = "fsl,imx6sx-lcdif"; > + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > reg = <0x02220000 0x4000>; > interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
On 01.11.24 14:54, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. > > Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep > "fsl,imx28-lcdif" for DT compatibility. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Thank you, Ahmad > --- > Changes since v3: > - None. > > arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++- > arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi > index 6aa61235e39e..840e19b2ca0f 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi > @@ -773,7 +773,8 @@ epdc: epdc@20f4000 { > }; > > lcdif: lcdif@20f8000 { > - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", > + "fsl,imx28-lcdif"; > reg = <0x020f8000 0x4000>; > interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clks IMX6SL_CLK_LCDIF_PIX>, > diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi > index 85fe2a4ab97a..eff83f5e5535 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi > @@ -648,7 +648,8 @@ pxp: pxp@20f0000 { > }; > > lcdif: lcd-controller@20f8000 { > - compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif"; > + compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif", > + "fsl,imx28-lcdif"; > reg = <0x020f8000 0x4000>; > interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 8e3a98aeec32..aa3204b6aff9 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -19,7 +19,6 @@ properties: - enum: - fsl,imx23-lcdif - fsl,imx28-lcdif - - fsl,imx6sx-lcdif - fsl,imx8mp-lcdif - fsl,imx93-lcdif - items: @@ -32,6 +31,10 @@ properties: - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - enum: + - fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif reg: maxItems: 1 @@ -182,7 +185,7 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> display-controller@2220000 { - compatible = "fsl,imx6sx-lcdif"; + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; reg = <0x02220000 0x4000>; interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,