| Message ID | 20241031194714.2398527-1-Frank.Li@nxp.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 28 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. > > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 350fb8f400f02..5952e6448ed47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -111,11 +111,27 @@ properties: > unevaluatedProperties: false > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: > DSI output port node to the panel or the next bridge > in the chain > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 Why are they indexed starting from 1? > + > required: > - port@0 > - port@1 > -- > 2.34.1 >
On Thu, Oct 31, 2024 at 09:59:26PM +0200, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > 1, 2, 3, and 4 for port@1. > > > > Fix below CHECK_DTB warnings: > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > index 350fb8f400f02..5952e6448ed47 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > @@ -111,11 +111,27 @@ properties: > > unevaluatedProperties: false > > > > port@1: > > - $ref: /schemas/graph.yaml#/properties/port > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > description: > > DSI output port node to the panel or the next bridge > > in the chain > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: array of physical DSI data lane indexes. > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > Why are they indexed starting from 1? Not sure, git grep -r data-lanes Documentation/devicetree/bindings/ Most start from 1. Not sure latest DT team's intention. Frank > > > + > > required: > > - port@0 > > - port@1 > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
On Thu, Oct 31, 2024 at 04:20:10PM -0400, Frank Li wrote: > On Thu, Oct 31, 2024 at 09:59:26PM +0200, Dmitry Baryshkov wrote: > > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > > 1, 2, 3, and 4 for port@1. > > > > > > Fix below CHECK_DTB warnings: > > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > index 350fb8f400f02..5952e6448ed47 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > @@ -111,11 +111,27 @@ properties: > > > unevaluatedProperties: false > > > > > > port@1: > > > - $ref: /schemas/graph.yaml#/properties/port > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > description: > > > DSI output port node to the panel or the next bridge > > > in the chain > > > > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + data-lanes: > > > + description: array of physical DSI data lane indexes. > > > + minItems: 1 > > > + items: > > > + - const: 1 > > > + - const: 2 > > > + - const: 3 > > > + - const: 4 > > > > Why are they indexed starting from 1? > > Not sure, git grep -r data-lanes Documentation/devicetree/bindings/ > Most start from 1. Not sure latest DT team's intention. They usually start from 1, because just before the property comes 'clock-lanes = <0>'. Otherwise in most of the cases the lanes are indexed from 0. > > Frank > > > > > > + > > > required: > > > - port@0 > > > - port@1 > > > -- > > > 2.34.1 > > > > > > > -- > > With best wishes > > Dmitry
On Thu, Oct 31, 2024 at 10:55:30PM +0200, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 04:20:10PM -0400, Frank Li wrote: > > On Thu, Oct 31, 2024 at 09:59:26PM +0200, Dmitry Baryshkov wrote: > > > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > > > 1, 2, 3, and 4 for port@1. > > > > > > > > Fix below CHECK_DTB warnings: > > > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > > index 350fb8f400f02..5952e6448ed47 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > > @@ -111,11 +111,27 @@ properties: > > > > unevaluatedProperties: false > > > > > > > > port@1: > > > > - $ref: /schemas/graph.yaml#/properties/port > > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > > + unevaluatedProperties: false > > > > description: > > > > DSI output port node to the panel or the next bridge > > > > in the chain > > > > > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > + properties: > > > > + data-lanes: > > > > + description: array of physical DSI data lane indexes. > > > > + minItems: 1 > > > > + items: > > > > + - const: 1 > > > > + - const: 2 > > > > + - const: 3 > > > > + - const: 4 > > > > > > Why are they indexed starting from 1? > > > > Not sure, git grep -r data-lanes Documentation/devicetree/bindings/ > > Most start from 1. Not sure latest DT team's intention. > > They usually start from 1, because just before the property comes > 'clock-lanes = <0>'. Otherwise in most of the cases the lanes are > indexed from 0. I'm not sure what the rule is for DSI, but for CSI we number data lanes starting at 1 regardless of whether or not the clock lane is configurable. Consistency help for driver implementations. > > > > + > > > > required: > > > > - port@0 > > > > - port@1
On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. Describe "why", not what the changes are. I can read the diff. Why is the IP has a configurable number of lanes... > > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 350fb8f400f02..5952e6448ed47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -111,11 +111,27 @@ properties: > unevaluatedProperties: false > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: > DSI output port node to the panel or the next bridge > in the chain > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > required: > - port@0 > - port@1 > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml index 350fb8f400f02..5952e6448ed47 100644 --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml @@ -111,11 +111,27 @@ properties: unevaluatedProperties: false port@1: - $ref: /schemas/graph.yaml#/properties/port + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false description: DSI output port node to the panel or the next bridge in the chain + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: array of physical DSI data lane indexes. + minItems: 1 + items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + required: - port@0 - port@1
Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' property referencing video-interfaces.yaml. Allow 'data-lanes' values 1, 2, 3, and 4 for port@1. Fix below CHECK_DTB warnings: arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)