mbox series

[unstable,linux-signed,v2,0/9] Refactor and test generate-control

Message ID 20241030132153.482139-1-agathe.porte@canonical.com
Headers show
Series Refactor and test generate-control | expand

Message

Agathe Porte Oct. 30, 2024, 1:19 p.m. UTC 
The goal of this patch set is to introduce some Python testing for the
generate-control script (which becomes generate_control.py).

In this v2 patchset the debian/scripts/test-generate-control.sh file is
dropped when the test_generate_control.py is introduced.

Agathe Porte (9):
  UBUNTU: [Packaging] generate-control: use stdin and stdout
  UBUNTU: [Packaging] introduce debian/scripts/test-generate-control.sh
  UBUNTU: [Packaging] generate-control: fix 'os' imported but unused
  UBUNTU: [Packaging] generate-control: reformat using black
  UBUNTU: [Packaging] generate-control: split into functions
  UBUNTU: [Packaging] generate-control: use full path to
    parameterise-ancillaries in comment
  UBUNTU: [Packaging] generate-control: rename to generate_control.py
  UBUNTU: [Packaging] generate_control.py: pass everything by argument
  UBUNTU: [Packaging] introduce test_generate_control.py

 debian/rules                            |   2 +-
 debian/scripts/generate-control         | 141 ---------------
 debian/scripts/generate_control.py      | 223 ++++++++++++++++++++++++
 debian/scripts/test_generate_control.py | 134 ++++++++++++++
 4 files changed, 358 insertions(+), 142 deletions(-)
 delete mode 100755 debian/scripts/generate-control
 create mode 100755 debian/scripts/generate_control.py
 create mode 100644 debian/scripts/test_generate_control.py

Comments

Masahiro Yamada Oct. 30, 2024, 2:42 p.m. UTC | #1 
On Wed, Oct 30, 2024 at 2:22 PM Agathe Porte <agathe.porte@canonical.com> wrote:
>
> The goal of this patch set is to introduce some Python testing for the
> generate-control script (which becomes generate_control.py).
>
> In this v2 patchset the debian/scripts/test-generate-control.sh file is
> dropped when the test_generate_control.py is introduced.
>
> Agathe Porte (9):
>   UBUNTU: [Packaging] generate-control: use stdin and stdout
>   UBUNTU: [Packaging] introduce debian/scripts/test-generate-control.sh
>   UBUNTU: [Packaging] generate-control: fix 'os' imported but unused
>   UBUNTU: [Packaging] generate-control: reformat using black
>   UBUNTU: [Packaging] generate-control: split into functions
>   UBUNTU: [Packaging] generate-control: use full path to
>     parameterise-ancillaries in comment
>   UBUNTU: [Packaging] generate-control: rename to generate_control.py
>   UBUNTU: [Packaging] generate_control.py: pass everything by argument
>   UBUNTU: [Packaging] introduce test_generate_control.py
>
>  debian/rules                            |   2 +-
>  debian/scripts/generate-control         | 141 ---------------
>  debian/scripts/generate_control.py      | 223 ++++++++++++++++++++++++
>  debian/scripts/test_generate_control.py | 134 ++++++++++++++
>  4 files changed, 358 insertions(+), 142 deletions(-)
>  delete mode 100755 debian/scripts/generate-control
>  create mode 100755 debian/scripts/generate_control.py
>  create mode 100644 debian/scripts/test_generate_control.py

Nice cleanups and improvements!

Acked-by: Masahiro Yamada <masahiro.yamada@canonical.com>
Paolo Pisati Oct. 30, 2024, 3:02 p.m. UTC | #2 
On Wed, Oct 30, 2024 at 02:19:47PM +0100, Agathe Porte wrote:
> The goal of this patch set is to introduce some Python testing for the
> generate-control script (which becomes generate_control.py).
> 
> In this v2 patchset the debian/scripts/test-generate-control.sh file is
> dropped when the test_generate_control.py is introduced.

Applied.