| Message ID | 20241025204029.2054399-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 2d93dfd519f0181f69cc61f2bb7674018552a925 |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] github: Remove ASLR entropy workaround. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Fri, Oct 25, 2024 at 10:41 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > The issue should be fixed by now. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> I was looking into this for dpdk GHA during last week and I came to the same conclusion. CI seems to agree. Acked-by: David Marchand <david.marchand@redhat.com>
On 10/25/24 22:40, Ilya Maximets wrote: > The issue should be fixed by now. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- Looks good to me! Acked-by: Dumitru Ceara <dceara@redhat.com> If you don't mind I'll cherry pick this to OVN too once it gets merged in OVS. Thanks, Dumitru
On 25 Oct 2024, at 22:40, Ilya Maximets wrote: > The issue should be fixed by now. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Removing this seems fine now. Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 25/10/2024 21:40, Ilya Maximets wrote: > The issue should be fixed by now. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > .github/workflows/build-and-test.yml | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml > index 6ed39ca80..827d3ae31 100644 > --- a/.github/workflows/build-and-test.yml > +++ b/.github/workflows/build-and-test.yml > @@ -241,14 +241,6 @@ jobs: > if: matrix.m32 != '' > run: sudo apt install -y gcc-multilib > > - - name: Reduce ASLR entropy > - if: matrix.sanitizers != '' > - # Asan in llvm 14 provided in ubuntu-22.04 is incompatible with > - # high-entropy ASLR configured in much newer kernels that GitHub > - # runners are using leading to random crashes: > - # https://github.com/actions/runner-images/issues/9491 > - run: sudo sysctl -w vm.mmap_rnd_bits=28 > - > - name: prepare > run: ./.ci/linux-prepare.sh > Acked-by: Kevin Traynor <ktraynor@redhat.com>
On 10/25/24 22:40, Ilya Maximets wrote: > The issue should be fixed by now. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > .github/workflows/build-and-test.yml | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml > index 6ed39ca80..827d3ae31 100644 > --- a/.github/workflows/build-and-test.yml > +++ b/.github/workflows/build-and-test.yml > @@ -241,14 +241,6 @@ jobs: > if: matrix.m32 != '' > run: sudo apt install -y gcc-multilib > > - - name: Reduce ASLR entropy > - if: matrix.sanitizers != '' > - # Asan in llvm 14 provided in ubuntu-22.04 is incompatible with > - # high-entropy ASLR configured in much newer kernels that GitHub > - # runners are using leading to random crashes: > - # https://github.com/actions/runner-images/issues/9491 > - run: sudo sysctl -w vm.mmap_rnd_bits=28 > - > - name: prepare > run: ./.ci/linux-prepare.sh > Thanks, David, Dumitru, Eelco and Kevin! Applied to all branches down to 2.17. Dumitru, feel free to take this to OVN. :) Best regards, Ilya Maximets.
On 10/30/24 17:44, Ilya Maximets wrote: > On 10/25/24 22:40, Ilya Maximets wrote: >> The issue should be fixed by now. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- >> .github/workflows/build-and-test.yml | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml >> index 6ed39ca80..827d3ae31 100644 >> --- a/.github/workflows/build-and-test.yml >> +++ b/.github/workflows/build-and-test.yml >> @@ -241,14 +241,6 @@ jobs: >> if: matrix.m32 != '' >> run: sudo apt install -y gcc-multilib >> >> - - name: Reduce ASLR entropy >> - if: matrix.sanitizers != '' >> - # Asan in llvm 14 provided in ubuntu-22.04 is incompatible with >> - # high-entropy ASLR configured in much newer kernels that GitHub >> - # runners are using leading to random crashes: >> - # https://github.com/actions/runner-images/issues/9491 >> - run: sudo sysctl -w vm.mmap_rnd_bits=28 >> - >> - name: prepare >> run: ./.ci/linux-prepare.sh >> > > Thanks, David, Dumitru, Eelco and Kevin! > > Applied to all branches down to 2.17. > > Dumitru, feel free to take this to OVN. :) > Applied to the OVN main branch too: https://github.com/ovn-org/ovn/commit/45d4c8e Regards, Dumitru
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 6ed39ca80..827d3ae31 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -241,14 +241,6 @@ jobs: if: matrix.m32 != '' run: sudo apt install -y gcc-multilib - - name: Reduce ASLR entropy - if: matrix.sanitizers != '' - # Asan in llvm 14 provided in ubuntu-22.04 is incompatible with - # high-entropy ASLR configured in much newer kernels that GitHub - # runners are using leading to random crashes: - # https://github.com/actions/runner-images/issues/9491 - run: sudo sysctl -w vm.mmap_rnd_bits=28 - - name: prepare run: ./.ci/linux-prepare.sh
The issue should be fixed by now. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- .github/workflows/build-and-test.yml | 8 -------- 1 file changed, 8 deletions(-)