| Message ID | 20241023-en7581-pinctrl-v9-0-afb0cbcab0ec@kernel.org |
|---|---|
| Headers | show |
| Series | Add mfd, pinctrl and pwm support to EN7581 SoC | expand |
On Wed, Oct 23, 2024 at 1:21 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > Introduce airoha-mfd driver in order to load pinctrl and pwm drivers for > EN7581 SoC. airoha-mfd is needed since both pinctrl and pwm drivers > needs to access the same memory block (gpio memory region) to configure > {gio,irq}_chip and pwm functionalities respectively, so model them as > childs of a parent mfd driver. OK someone has to merge this and I suggest that I merge patches 1-5 (all bindings and the pinctrl driver) since the different bindings have dependencies between them. Then Uwe can merge patch 6/6 (the pwm driver). Anyone against? Yours, Linus Walleij
Hello Linus, On Tue, Oct 29, 2024 at 11:03:14PM +0100, Linus Walleij wrote: > On Wed, Oct 23, 2024 at 1:21 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > Introduce airoha-mfd driver in order to load pinctrl and pwm drivers for > > EN7581 SoC. airoha-mfd is needed since both pinctrl and pwm drivers > > needs to access the same memory block (gpio memory region) to configure > > {gio,irq}_chip and pwm functionalities respectively, so model them as > > childs of a parent mfd driver. > > OK someone has to merge this and I suggest that I merge patches 1-5 > (all bindings and the pinctrl driver) since the different bindings have > dependencies between them. Fine for me. > Then Uwe can merge patch 6/6 (the pwm driver). The pwm patch needs some more love, we can handle that separately then. Best regards and thanks, Uwe
On Wed, Oct 30, 2024 at 08:34:01AM +0100, Uwe Kleine-König wrote: > Hello Linus, > > On Tue, Oct 29, 2024 at 11:03:14PM +0100, Linus Walleij wrote: > > On Wed, Oct 23, 2024 at 1:21 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > > > Introduce airoha-mfd driver in order to load pinctrl and pwm drivers for > > > EN7581 SoC. airoha-mfd is needed since both pinctrl and pwm drivers > > > needs to access the same memory block (gpio memory region) to configure > > > {gio,irq}_chip and pwm functionalities respectively, so model them as > > > childs of a parent mfd driver. > > > > OK someone has to merge this and I suggest that I merge patches 1-5 > > (all bindings and the pinctrl driver) since the different bindings have > > dependencies between them. > > Fine for me. > > > Then Uwe can merge patch 6/6 (the pwm driver). > > The pwm patch needs some more love, we can handle that separately then. > Thanks for the feedback, so I assume we will detach the DT and PWM driver from this driver and handle it separately.
> On Wed, Oct 30, 2024 at 08:34:01AM +0100, Uwe Kleine-König wrote: > > Hello Linus, > > > > On Tue, Oct 29, 2024 at 11:03:14PM +0100, Linus Walleij wrote: > > > On Wed, Oct 23, 2024 at 1:21 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > > > > > Introduce airoha-mfd driver in order to load pinctrl and pwm drivers for > > > > EN7581 SoC. airoha-mfd is needed since both pinctrl and pwm drivers > > > > needs to access the same memory block (gpio memory region) to configure > > > > {gio,irq}_chip and pwm functionalities respectively, so model them as > > > > childs of a parent mfd driver. > > > > > > OK someone has to merge this and I suggest that I merge patches 1-5 > > > (all bindings and the pinctrl driver) since the different bindings have > > > dependencies between them. > > > > Fine for me. > > > > > Then Uwe can merge patch 6/6 (the pwm driver). > > > > The pwm patch needs some more love, we can handle that separately then. > > > > Thanks for the feedback, so I assume we will detach the DT and PWM > driver from this driver and handle it separately. Yep, discussing with Linus, he is fine to get patches {1/6-5/6} via pinctrl tree while patch 6/6 can go via Uwe's one. It seems we are good for patches {1/6-5/6} and I will fix patch 6/6 separately. Regards, Lorenzo > > -- > Ansuel
On Tue, Oct 29, 2024 at 11:03 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Oct 23, 2024 at 1:21 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > > Introduce airoha-mfd driver in order to load pinctrl and pwm drivers for > > EN7581 SoC. airoha-mfd is needed since both pinctrl and pwm drivers > > needs to access the same memory block (gpio memory region) to configure > > {gio,irq}_chip and pwm functionalities respectively, so model them as > > childs of a parent mfd driver. > > OK someone has to merge this and I suggest that I merge patches 1-5 > (all bindings and the pinctrl driver) since the different bindings have > dependencies between them. OK I have now merged patches 1-5 to the pinctrl tree. Please iterate patch 6 with the PWM people so Uwe can merge it when finished. Yours, Linus Walleij
Introduce airoha-mfd driver in order to load pinctrl and pwm drivers for EN7581 SoC. airoha-mfd is needed since both pinctrl and pwm drivers needs to access the same memory block (gpio memory region) to configure {gio,irq}_chip and pwm functionalities respectively, so model them as childs of a parent mfd driver. Current EN7581 pinctrl driver supports the following functionalities: - pin multiplexing via chip_scu syscon - pin pull-up, pull-down, open-drain, current strength, {input,output}_enable, output_{low,high} via chip_scu syscon - gpio controller - irq controller --- Changes in v9: - pwm: remove unused properties - Link to v8: https://lore.kernel.org/r/20241018-en7581-pinctrl-v8-0-b676b966a1d1@kernel.org Changes in v8: - pwm: add missing properties documentation - Link to v7: https://lore.kernel.org/r/20241016-en7581-pinctrl-v7-0-4ff611f263a7@kernel.org Changes in v7: - pinctrl: cosmetics - pinctrl: fix compilation warning - Link to v6: https://lore.kernel.org/r/20241013-en7581-pinctrl-v6-0-2048e2d099c2@kernel.org Changes in v6: - pwm: rely on regmap APIs - pwm: introduce compatible string - pinctrl: introduce compatible string - remove airoha-mfd driver - add airoha,en7581-pinctrl binding - add airoha,en7581-pwm binding - update airoha,en7581-gpio-sysctl binding - Link to v5: https://lore.kernel.org/r/20241001-en7581-pinctrl-v5-0-dc1ce542b6c6@kernel.org Changes in v5: - use spin_lock in airoha_pinctrl_rmw instead of a mutex since it can run in interrupt context - remove unused includes in pinctrl driver - since the irq_chip is immutable, allocate the gpio_irq_chip struct statically in pinctrl driver - rely on regmap APIs in pinctrl driver but keep the spin_lock local to the driver - rely on guard/guard_scope APIs in pinctrl driver - improve naming convention pinctrl driver - introduce airoha_pinconf_set_pin_value utility routine - Link to v4: https://lore.kernel.org/r/20240911-en7581-pinctrl-v4-0-60ac93d760bb@kernel.org Changes in v4: - add 'Limitation' description in pwm driver - fix comments in pwm driver - rely on mfd->base __iomem pointer in pwm driver, modify register offsets according to it and get rid of sgpio_cfg, flash_cfg and cycle_cfg pointers - simplify register utility routines in pwm driver - use 'generator' instead of 'waveform' suffix for pwm routines - fix possible overflow calculating duty cycle in pwm driver - do not modify pwm state in free callback in pwm driver - cap the maximum period in pwm driver - do not allow inverse polarity in pwm driver - do not set of_xlate callback in the pwm driver and allow the stack to do it - fix MAINTAINERS file for airoha pinctrl driver - fix undefined reference to __ffsdi2 in pinctrl driver - simplify airoha,en7581-gpio-sysctl.yam binding - Link to v3: https://lore.kernel.org/r/20240831-en7581-pinctrl-v3-0-98eebfb4da66@kernel.org Changes in v3: - introduce airoha-mfd driver - add pwm driver to the same series - model pinctrl and pwm drivers as childs of a parent mfd driver. - access chip-scu memory region in pinctrl driver via syscon - introduce a single airoha,en7581-gpio-sysctl.yaml binding and get rid of dedicated bindings for pinctrl and pwm - add airoha,en7581-chip-scu.yaml binding do the series - Link to v2: https://lore.kernel.org/r/20240822-en7581-pinctrl-v2-0-ba1559173a7f@kernel.org Changes in v2: - Fix compilation errors - Collapse some register mappings for gpio and irq controllers - update dt-bindings according to new register mapping - fix some dt-bindings errors - Link to v1: https://lore.kernel.org/all/cover.1723392444.git.lorenzo@kernel.org/ --- Benjamin Larsson (1): pwm: airoha: Add support for EN7581 SoC Christian Marangi (1): dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller Lorenzo Bianconi (4): dt-bindings: arm: airoha: Add the chip-scu node for EN7581 SoC dt-bindings: pinctrl: airoha: Add EN7581 pinctrl dt-bindings: pwm: airoha: Add EN7581 pwm pinctrl: airoha: Add support for EN7581 SoC .../bindings/arm/airoha,en7581-chip-scu.yaml | 42 + .../bindings/mfd/airoha,en7581-gpio-sysctl.yaml | 90 + .../bindings/pinctrl/airoha,en7581-pinctrl.yaml | 400 +++ .../devicetree/bindings/pwm/airoha,en7581-pwm.yaml | 34 + MAINTAINERS | 7 + drivers/pinctrl/mediatek/Kconfig | 17 +- drivers/pinctrl/mediatek/Makefile | 1 + drivers/pinctrl/mediatek/pinctrl-airoha.c | 2970 ++++++++++++++++++++ drivers/pwm/Kconfig | 11 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-airoha.c | 386 +++ 11 files changed, 3958 insertions(+), 1 deletion(-) --- base-commit: 712a7891b8b68467edb10dc4dbc3eb11805d5795 change-id: 20240818-en7581-pinctrl-1bf120154be0 prerequisite-change-id: 20240705-for-6-11-bpf-a349efc08df8:v2 Best regards,