diff mbox series

support/kconfig: fix linux header path

Message ID 20241029113052.1243078-1-dungeonlords789@naver.com
State Changes Requested
Headers show
Series support/kconfig: fix linux header path | expand

Commit Message

Cherniaev Andrei Oct. 29, 2024, 11:30 a.m. UTC
Usually you will never have "/usr/src/linux"... For example on my Ubuntu 24 I have "/usr/src/linux-headers-6.8.0-47-generic". My change makes path universal.
---
 support/kconfig/README.buildroot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Oct. 29, 2024, 5:11 p.m. UTC | #1
Hello,

On Tue, 29 Oct 2024 20:30:51 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:

> Usually you will never have "/usr/src/linux"... For example on my Ubuntu 24 I have "/usr/src/linux-headers-6.8.0-47-generic". My change makes path universal.

Thanks for your patch. However, it cannot be applied as you did not
Signed-off-by on your patch.

Also, please wrap your commit message to 80 columns.

> diff --git a/support/kconfig/README.buildroot b/support/kconfig/README.buildroot
> index 76808f85b4..c08970c87e 100644
> --- a/support/kconfig/README.buildroot
> +++ b/support/kconfig/README.buildroot
> @@ -2,7 +2,7 @@ This is a copy of the kconfig code in the kernel (currently 4.17-rc2) tweaked
>  to suit Buildroot.
>  
>  To update:
> -	cp -r /usr/src/linux/scripts/kconfig support/kconfig.new
> +	cp -r /usr/src/linux-headers-$(uname -r)/scripts/kconfig support/kconfig.new

I actually don't think /usr/src/linux-headers-$(uname -r) is any
better. Most people who are interested in this will have their Linux
kernel source code cloned from Git, in some totally different location.
So perhaps:

"""
To update, assuming $KSRC points to a Linux kernel source tree:
	cp -a $KSRC/scripts/kconfig support/kconfig.new
	...
"""

Best regards,

Thomas
diff mbox series

Patch

diff --git a/support/kconfig/README.buildroot b/support/kconfig/README.buildroot
index 76808f85b4..c08970c87e 100644
--- a/support/kconfig/README.buildroot
+++ b/support/kconfig/README.buildroot
@@ -2,7 +2,7 @@  This is a copy of the kconfig code in the kernel (currently 4.17-rc2) tweaked
 to suit Buildroot.
 
 To update:
-	cp -r /usr/src/linux/scripts/kconfig support/kconfig.new
+	cp -r /usr/src/linux-headers-$(uname -r)/scripts/kconfig support/kconfig.new
 	cd support/kconfig.new
 	# zconf.lex.c and zconf.tab.c needs to be generated by 'make menuconfig'
 	mv zconf.lex.c zconf.lex.c_shipped